Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trim down EE10 DefaultServlet #10739

Closed
lorban opened this issue Oct 16, 2023 · 2 comments · Fixed by #11933
Closed

Trim down EE10 DefaultServlet #10739

lorban opened this issue Oct 16, 2023 · 2 comments · Fixed by #11933
Assignees
@lorban
Labels
Enhancement

Comments

@lorban
Copy link
Contributor

lorban commented Oct 16, 2023 •
edited
Loading

Jetty version(s)
12.0.x

Enhancement Description
Currently, the EE10 DefaultServlet tries to do too many things: being the default servlet bound to the root of the context as well as a general-purpose resource-serving servlet, and some requirements of both facets sometimes clash with each other.

DefaultServlet should be simplified to just be the bare-bone servlet meant to be bound to the root of the context and nothing else.

See #10738 for the ResourceServlet issue.
This was referenced Oct 16, 2023
Closed
Closed
@lorban lorban mentioned this issue May 17, 2024
Closed
@joakime
Copy link
Contributor

joakime commented Jun 25, 2024

@lorban haven't we kinda done this with the ResourceServlet work?

@lorban lorban linked a pull request Jun 26, 2024 that will close this issue
Jetty 12.0.x resource Servlet #11933
Merged
@lorban
Copy link
Contributor Author

lorban commented Jun 26, 2024 •
edited by joakime
Loading

@joakime yes, it looks like #11933 is addressing both this issue and #10738 so I've linked the PR to close this bug too when merged. Thanks for the reminder!

@joakime joakime moved this to 🏗 In progress in 🧊 Jetty 12.0.11 - FROZEN Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lorban lorban

Labels
Enhancement
Projects
No open projects
🧊 Jetty 12.0.12 - FROZEN
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Jetty 12.0.x resource Servlet jetty/jetty.project
2 participants
@joakime @lorban