Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review usage of ResourceFactory for favicon and stylesheet #8450

Closed
gregw opened this issue Aug 11, 2022 · 1 comment
Closed

Review usage of ResourceFactory for favicon and stylesheet #8450

gregw opened this issue Aug 11, 2022 · 1 comment
Labels
Bug For general bugs on Jetty side

Comments

@gregw
Copy link
Contributor

gregw commented Aug 11, 2022

Jetty version(s)
12

Description

Recent CI builds of 12 have failed because mounts have been left for the server.jar for favicon.ico. This should have been closed when the server was stopped, so that is the first issue. But moreover, the mechanism is too expensive to use for favicon.ico, as we need not hold an entire jar in memory as a zipfs when the bytes we need are available via the classloader.
@gregw gregw added the Bug For general bugs on Jetty side label Aug 11, 2022
@olamy olamy moved this to To do in Jetty 12.0.ALPHAS Sep 7, 2022
@joakime
Copy link
Contributor

joakime commented Jan 26, 2023

This has been addressed over a few PRs.
Most recently with @lachlan-roberts PR #9043

@joakime joakime closed this as completed Jan 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug For general bugs on Jetty side
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gregw @joakime