Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Azure - omit empty values in UpdatePullRequest #123

Merged
merged 4 commits into from
Nov 22, 2023
Merged

Azure - omit empty values in UpdatePullRequest #123

merged 4 commits into from
Nov 22, 2023

Conversation

omerzi
Copy link
Member

@omerzi omerzi commented Nov 22, 2023 •
edited
Loading

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • I used go fmt ./... for formatting the code before submitting the pull request.
  • This feature is included on all supported VCS providers - GitHub, Bitbucket cloud, Bitbucket server, GitLab and Azure Repos.
  • I added the relevant documentation for the new feature.

@omerzi omerzi added the bug Something isn't working label Nov 22, 2023
@omerzi omerzi requested a review from yahavi November 22, 2023 07:09
yahavi
yahavi suggested changes Nov 22, 2023
View reviewed changes
vcsutils/utils.go Show resolved Hide resolved
@omerzi omerzi changed the title Azure - ommit empty values in UpdatePullRequest Azure - omit empty values in UpdatePullRequest Nov 22, 2023
@omerzi omerzi merged commit 98830f1 into jfrog:master Nov 22, 2023
5 of 6 checks passed
@omerzi omerzi deleted the ommit-empty-values-update-pr branch November 22, 2023 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yahavi yahavi yahavi requested changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@omerzi @yahavi