Add get commit status #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lement_get_commit_status
…lement_get_commit_status
…Delarea/froggit-go into implement_get_commit_status
3 tasks
yahavi
suggested changes
Mar 22, 2023
There was a problem hiding this comment.
Well done, @EyalDelarea!
Please consider my inline comments.
Also as general notes:
- For the sake of good order, the methods implementations order should be in the same order as in the vcsclient.go. I'd do the same for the tests.
- Tests methods should be above private test utilities (for instance, TestGitHubClient_TestGetCommitStatus should be above createBadGitHubClient)
- Let's also document this change in the README
…and default time object fall back
…lement_get_commit_status
refactor
yahavi
suggested changes
Mar 26, 2023
yahavi
approved these changes
Mar 27, 2023
EyalDelarea
added
new feature
EyalDelarea
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
go fmt ./...for formatting the code before submitting the pull request.Implemented get commit status function in all VCS providers
and also implement setCommitStatus on azure repos