Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GitHub cloud remote URLs #83

Merged
merged 4 commits into from
May 11, 2023

Conversation

EyalDelarea
Copy link
Contributor

@EyalDelarea EyalDelarea commented May 7, 2023

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • I used go fmt ./... for formatting the code before submitting the pull request.
  • This feature is included on all supported VCS providers - GitHub, Bitbucket cloud, Bitbucket server, and GitLab.

Bug description:
When downloading a repo from GitHub cloud, the ApiEndpoint was set to api.github.com
and it was used to set the remote urls as well as https://api.github.com/my-org/my-repo.git
this is wrong as the remote url should be the GitHub host url which is https://github.com/my-org/my-repo.git

Bitbucket server & cloud is working correctly.
GitLab on perm & cloud is also working correctly.

@EyalDelarea EyalDelarea added the bug Something isn't working label May 7, 2023
@EyalDelarea EyalDelarea temporarily deployed to frogbot May 7, 2023 13:03 — with GitHub Actions Inactive
@EyalDelarea EyalDelarea requested a review from yahavi May 7, 2023 13:08
@EyalDelarea EyalDelarea changed the title Fix GitHub remote URLs Fix GitHub cloud remote URLs May 7, 2023
@github-actions
Copy link
Contributor

github-actions bot commented May 7, 2023

What is Frogbot?

@eyalbe4 eyalbe4 merged commit 03d12f4 into jfrog:master May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants