Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add istio podAnnotations to hermes helmchart #49

Open
jgomezselles opened this issue May 11, 2021 · 0 comments
Open

Add istio podAnnotations to hermes helmchart #49

jgomezselles opened this issue May 11, 2021 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@jgomezselles
Copy link
Owner

Right now, sidecar injection is done with a flag in the values.yaml file, and expanded in the deployment template.
Instead of that, podAnnotations shall be used as in hermes-example
@jgomezselles jgomezselles added enhancement New feature or request good first issue Good for newcomers labels May 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jgomezselles