From 7323cd222ece7fa32a093a02d29d128adfc0d810 Mon Sep 17 00:00:00 2001
From: Quentin Monmert <quentin.monmert@gmail.com>
Date: Sun, 4 Jul 2021 14:45:53 +0200
Subject: [PATCH] [React] Clean code

---
 .../src/main/webapp/app/config/notification-middleware.ts.ejs | 3 +--
 .../app/modules/account/settings/settings.reducer.ts.ejs      | 2 +-
 .../src/main/webapp/app/shared/layout/footer/footer.tsx.ejs   | 2 +-
 .../webapp/app/shared/layout/header/header-components.tsx.ejs | 4 ++--
 .../src/main/webapp/app/shared/reducers/reducer.utils.ts.ejs  | 1 -
 5 files changed, 5 insertions(+), 7 deletions(-)

diff --git a/generators/client/templates/react/src/main/webapp/app/config/notification-middleware.ts.ejs b/generators/client/templates/react/src/main/webapp/app/config/notification-middleware.ts.ejs
index 97367d3134f..eb13e36a6a3 100644
--- a/generators/client/templates/react/src/main/webapp/app/config/notification-middleware.ts.ejs
+++ b/generators/client/templates/react/src/main/webapp/app/config/notification-middleware.ts.ejs
@@ -73,7 +73,6 @@ export default () => next => action => {
           (error.message === '' || (data && data.path && (data.path.includes('/api/account') || data.path.includes('/api/authenticate'))))
         )
       ) {
-        let i;
         switch (response.status) {
           // connection refused, server not reachable
           case 0:
@@ -98,7 +97,7 @@ export default () => next => action => {
               addErrorAlert(errorHeader, errorHeader, { entityName });
             } else if (data?.fieldErrors) {
               const fieldErrors = data.fieldErrors;
-              for (i = 0; i < fieldErrors.length; i++) {
+              for (let i = 0; i < fieldErrors.length; i++) {
                 const fieldError = fieldErrors[i];
                 if (['Min', 'Max', 'DecimalMin', 'DecimalMax'].includes(fieldError.message)) {
                     fieldError.message = 'Size';
diff --git a/generators/client/templates/react/src/main/webapp/app/modules/account/settings/settings.reducer.ts.ejs b/generators/client/templates/react/src/main/webapp/app/modules/account/settings/settings.reducer.ts.ejs
index 096617f37ab..a72a984ca32 100644
--- a/generators/client/templates/react/src/main/webapp/app/modules/account/settings/settings.reducer.ts.ejs
+++ b/generators/client/templates/react/src/main/webapp/app/modules/account/settings/settings.reducer.ts.ejs
@@ -70,7 +70,7 @@ export const SettingsSlice = createSlice({
         state.errorMessage = null;
         state.updateSuccess = false;
       })
-      .addCase(updateAccount.rejected, (state, action) => {
+      .addCase(updateAccount.rejected, state => {
         state.loading = false;
         state.updateSuccess = false;
         state.updateFailure = true;
diff --git a/generators/client/templates/react/src/main/webapp/app/shared/layout/footer/footer.tsx.ejs b/generators/client/templates/react/src/main/webapp/app/shared/layout/footer/footer.tsx.ejs
index beac150a94d..ed5179254d1 100644
--- a/generators/client/templates/react/src/main/webapp/app/shared/layout/footer/footer.tsx.ejs
+++ b/generators/client/templates/react/src/main/webapp/app/shared/layout/footer/footer.tsx.ejs
@@ -22,7 +22,7 @@ import React from 'react';
 import { Translate } from 'react-jhipster';
 import { Col, Row } from 'reactstrap';
 
-const Footer = props => (
+const Footer = () => (
   <div className="footer page-content">
     <Row>
       <Col md="12">
diff --git a/generators/client/templates/react/src/main/webapp/app/shared/layout/header/header-components.tsx.ejs b/generators/client/templates/react/src/main/webapp/app/shared/layout/header/header-components.tsx.ejs
index 8aab054a0eb..a9176202e7d 100644
--- a/generators/client/templates/react/src/main/webapp/app/shared/layout/header/header-components.tsx.ejs
+++ b/generators/client/templates/react/src/main/webapp/app/shared/layout/header/header-components.tsx.ejs
@@ -34,7 +34,7 @@ export const BrandIcon = props => (
   </div>
 );
 
-export const Brand = props => (
+export const Brand = () => (
 <NavbarBrand tag={Link} to="/" className="brand-logo">
   <BrandIcon />
   <span className="brand-title"><Translate contentKey="global.title"><%= capitalizedBaseName %></Translate></span>
@@ -42,7 +42,7 @@ export const Brand = props => (
 </NavbarBrand>
 );
 
-export const Home = props => (
+export const Home = () => (
   <NavItem>
     <NavLink tag={Link} to="/" className="d-flex align-items-center">
       <FontAwesomeIcon icon="home" />
diff --git a/generators/client/templates/react/src/main/webapp/app/shared/reducers/reducer.utils.ts.ejs b/generators/client/templates/react/src/main/webapp/app/shared/reducers/reducer.utils.ts.ejs
index 07bc2ab9394..4c6b04d6767 100644
--- a/generators/client/templates/react/src/main/webapp/app/shared/reducers/reducer.utils.ts.ejs
+++ b/generators/client/templates/react/src/main/webapp/app/shared/reducers/reducer.utils.ts.ejs
@@ -21,7 +21,6 @@ import {
   AsyncThunk,
   ActionReducerMapBuilder,
   createSlice,
-  PayloadAction,
   SerializedError,
   SliceCaseReducers,
   ValidateSliceCaseReducers,