From 441329afbd8ce2ade1b021c56e4ab6caa470b4f1 Mon Sep 17 00:00:00 2001 From: Quentin Date: Thu, 30 May 2024 23:12:50 +0200 Subject: [PATCH] Cypress: Fix warn 'response is possibly undefined' --- .../cypress/e2e/account/login-page.cy.ts.ejs | 8 ++++---- .../e2e/account/password-page.cy.ts.ejs | 4 ++-- .../e2e/account/register-page.cy.ts.ejs | 2 +- .../e2e/account/reset-password-page.cy.ts.ejs | 2 +- .../cypress/e2e/entity/_entity_.cy.ts.ejs | 20 +++++++++---------- 5 files changed, 18 insertions(+), 18 deletions(-) diff --git a/generators/cypress/templates/src/test/javascript/cypress/e2e/account/login-page.cy.ts.ejs b/generators/cypress/templates/src/test/javascript/cypress/e2e/account/login-page.cy.ts.ejs index 8344d4a670fd..f5575e3c3796 100644 --- a/generators/cypress/templates/src/test/javascript/cypress/e2e/account/login-page.cy.ts.ejs +++ b/generators/cypress/templates/src/test/javascript/cypress/e2e/account/login-page.cy.ts.ejs @@ -52,7 +52,7 @@ describe('login modal', () => { cy.get(passwordLoginSelector).type('a-password'); cy.get(submitLoginSelector).click(); <%_ if (!clientFrameworkReact) { _%> - cy.wait('@authenticate').then(({ response }) => expect(response.statusCode).to.equal(<% if (authenticationTypeSession) { %>401<% } else { %>400<% } %>)); + cy.wait('@authenticate').then(({ response }) => expect(response?.statusCode).to.equal(<% if (authenticationTypeSession) { %>401<% } else { %>400<% } %>)); <%_ } _%> // login page should stay open when login fails cy.get(titleLoginSelector).should('be.visible'); @@ -62,7 +62,7 @@ describe('login modal', () => { cy.get(usernameLoginSelector).type('a-login'); cy.get(submitLoginSelector).click(); <%_ if (!clientFrameworkReact) { _%> - cy.wait('@authenticate').then(({ response }) => expect(response.statusCode).to.equal(<% if (authenticationTypeSession) { %>401<% } else { %>400<% } %>)); + cy.wait('@authenticate').then(({ response }) => expect(response?.statusCode).to.equal(<% if (authenticationTypeSession) { %>401<% } else { %>400<% } %>)); cy.get(errorLoginSelector).should('be.visible'); <%_ } else { _%> // login page should stay open when login fails @@ -74,7 +74,7 @@ describe('login modal', () => { cy.get(usernameLoginSelector).type(username); cy.get(passwordLoginSelector).type('bad-password'); cy.get(submitLoginSelector).click(); - cy.wait('@authenticate').then(({ response }) => expect(response.statusCode).to.equal(401)); + cy.wait('@authenticate').then(({ response }) => expect(response?.statusCode).to.equal(401)); cy.get(errorLoginSelector).should('be.visible'); }); @@ -82,7 +82,7 @@ describe('login modal', () => { cy.get(usernameLoginSelector).type(username); cy.get(passwordLoginSelector).type(password); cy.get(submitLoginSelector).click(); - cy.wait('@authenticate').then(({ response }) => expect(response.statusCode).to.equal(200)); + cy.wait('@authenticate').then(({ response }) => expect(response?.statusCode).to.equal(200)); cy.hash().should('eq', ''); }); }); diff --git a/generators/cypress/templates/src/test/javascript/cypress/e2e/account/password-page.cy.ts.ejs b/generators/cypress/templates/src/test/javascript/cypress/e2e/account/password-page.cy.ts.ejs index 6ca130dcbf30..f8e5419dc7e5 100644 --- a/generators/cypress/templates/src/test/javascript/cypress/e2e/account/password-page.cy.ts.ejs +++ b/generators/cypress/templates/src/test/javascript/cypress/e2e/account/password-page.cy.ts.ejs @@ -80,7 +80,7 @@ describe('/account/password', () => { cy.get(newPasswordSelector).type('jhipster'); cy.get(confirmPasswordSelector).type('jhipster'); cy.get(submitPasswordSelector).click(); - cy.wait('@passwordSave').then(({ response }) => expect(response.statusCode).to.equal(400)); + cy.wait('@passwordSave').then(({ response }) => expect(response?.statusCode).to.equal(400)); }); it("should be able to update password", () => { @@ -88,6 +88,6 @@ describe('/account/password', () => { cy.get(newPasswordSelector).type(password); cy.get(confirmPasswordSelector).type(password); cy.get(submitPasswordSelector).click(); - cy.wait('@passwordSave').then(({ response }) => expect(response.statusCode).to.equal(200)); + cy.wait('@passwordSave').then(({ response }) => expect(response?.statusCode).to.equal(200)); }); }); diff --git a/generators/cypress/templates/src/test/javascript/cypress/e2e/account/register-page.cy.ts.ejs b/generators/cypress/templates/src/test/javascript/cypress/e2e/account/register-page.cy.ts.ejs index b99ef0a45507..78f8c4047c31 100644 --- a/generators/cypress/templates/src/test/javascript/cypress/e2e/account/register-page.cy.ts.ejs +++ b/generators/cypress/templates/src/test/javascript/cypress/e2e/account/register-page.cy.ts.ejs @@ -128,6 +128,6 @@ describe('<%= registerPage %>', () => { cy.get(firstPasswordRegisterSelector).type('jondoe'); cy.get(secondPasswordRegisterSelector).type('jondoe'); cy.get(submitRegisterSelector).click(); - cy.wait('@registerSave').then(({ response }) => expect(response.statusCode).to.equal(201)); + cy.wait('@registerSave').then(({ response }) => expect(response?.statusCode).to.equal(201)); }); }); diff --git a/generators/cypress/templates/src/test/javascript/cypress/e2e/account/reset-password-page.cy.ts.ejs b/generators/cypress/templates/src/test/javascript/cypress/e2e/account/reset-password-page.cy.ts.ejs index 57957fe172ef..2be89f915737 100644 --- a/generators/cypress/templates/src/test/javascript/cypress/e2e/account/reset-password-page.cy.ts.ejs +++ b/generators/cypress/templates/src/test/javascript/cypress/e2e/account/reset-password-page.cy.ts.ejs @@ -54,6 +54,6 @@ describe('forgot your password', () => { it('should be able to init reset password', () => { cy.get(emailResetPasswordSelector).type('user@gmail.com'); cy.get(submitInitResetPasswordSelector).click({ force: true }); - cy.wait('@initResetPassword').then(({ response }) => expect(response.statusCode).to.equal(200)); + cy.wait('@initResetPassword').then(({ response }) => expect(response?.statusCode).to.equal(200)); }); }); diff --git a/generators/cypress/templates/src/test/javascript/cypress/e2e/entity/_entity_.cy.ts.ejs b/generators/cypress/templates/src/test/javascript/cypress/e2e/entity/_entity_.cy.ts.ejs index 8e126b5db1bb..c1e7babd9760 100644 --- a/generators/cypress/templates/src/test/javascript/cypress/e2e/entity/_entity_.cy.ts.ejs +++ b/generators/cypress/templates/src/test/javascript/cypress/e2e/entity/_entity_.cy.ts.ejs @@ -146,7 +146,7 @@ describe('<%= entityClass %> e2e test', () => { cy.visit('/'); cy.clickOnEntityMenuItem('<%= entityPage %>'); cy.wait('@entitiesRequest').then(({ response }) => { - if (response.body.length === 0) { + if (response?.body.length === 0) { cy.get(entityTableSelector).should('not.exist'); } else { cy.get(entityTableSelector).should('exist'); @@ -171,7 +171,7 @@ describe('<%= entityClass %> e2e test', () => { cy.get(entityCreateSaveButtonSelector).should('exist'); cy.get(entityCreateCancelButtonSelector).click(); cy.wait('@entitiesRequest').then(({ response }) => { - expect(response.statusCode).to.equal(200); + expect(response?.statusCode).to.equal(200); }); cy.url().should('match', <%= entityInstance %>PageUrlPattern); }); @@ -232,7 +232,7 @@ describe('<%= entityClass %> e2e test', () => { cy.visit(<%= entityInstance %>PageUrl); cy.wait('@entitiesRequest').then(({ response }) => { - if (response.body.length === 0) { + if (response?.body.length === 0) { this.skip(); } }); @@ -244,7 +244,7 @@ describe('<%= entityClass %> e2e test', () => { cy.getEntityDetailsHeading('<%= entityInstance %>'); cy.get(entityDetailsBackButtonSelector).click(); cy.wait('@entitiesRequest').then(({ response }) => { - expect(response.statusCode).to.equal(200); + expect(response?.statusCode).to.equal(200); }); cy.url().should('match', <%= entityInstance %>PageUrlPattern); }); @@ -256,7 +256,7 @@ describe('<%= entityClass %> e2e test', () => { cy.get(entityCreateSaveButtonSelector).should('exist'); cy.get(entityCreateCancelButtonSelector).click(); cy.wait('@entitiesRequest').then(({ response }) => { - expect(response.statusCode).to.equal(200); + expect(response?.statusCode).to.equal(200); }); cy.url().should('match', <%= entityInstance %>PageUrlPattern); }); @@ -266,7 +266,7 @@ describe('<%= entityClass %> e2e test', () => { cy.getEntityCreateUpdateHeading('<%= entityClass %>'); cy.get(entityCreateSaveButtonSelector).click(); cy.wait('@entitiesRequest').then(({ response }) => { - expect(response.statusCode).to.equal(200); + expect(response?.statusCode).to.equal(200); }); cy.url().should('match', <%= entityInstance %>PageUrlPattern); }); @@ -284,10 +284,10 @@ describe('<%= entityClass %> e2e test', () => { cy.getEntityDeleteDialogHeading('<%= entityInstance %>').should('exist'); cy.get(entityConfirmDeleteButtonSelector).click(); cy.wait('@deleteEntityRequest').then(({ response }) => { - expect(response.statusCode).to.equal(204); + expect(response?.statusCode).to.equal(204); }); cy.wait('@entitiesRequest').then(({ response }) => { - expect(response.statusCode).to.equal(200); + expect(response?.statusCode).to.equal(200); }); cy.url().should('match', <%= entityInstance %>PageUrlPattern); <% if (cypressBootstrapEntities) { %> @@ -351,11 +351,11 @@ describe('<%= entityClass %> e2e test', () => { cy.get(entityCreateSaveButtonSelector).click(); cy.wait('@postEntityRequest').then(({ response }) => { - expect(response.statusCode).to.equal(201); + expect(response?.statusCode).to.equal(201); <%= entityInstance %> = response.body; }); cy.wait('@entitiesRequest').then(({ response }) => { - expect(response.statusCode).to.equal(200); + expect(response?.statusCode).to.equal(200); }); cy.url().should('match', <%= entityInstance %>PageUrlPattern); });