Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to cypress implementation. #14441

Closed
1 task
mshima opened this issue Mar 24, 2021 · 3 comments
Closed
1 task

Improvements to cypress implementation. #14441

mshima opened this issue Mar 24, 2021 · 3 comments

Comments

@mshima
Copy link
Member

mshima commented Mar 24, 2021

Overview of the issue

While doing some work related to #14103.
I've found some problems and improvements that we could make in our cypress implementation.

  • Our tests could reduce roundtrips eg:
    • First test executes go to main page -> open menu -> go to entity page -> do some checks.
    • Every other test executes the first test + some other test.
  • Remove unnecessary page visits.
  • Our tests executes with prod profile, which doesn't includes fake data.
    Many tests are actually not executed at all without a registry in database, but reported as succeeded instead of skipped.
Motivation for or Use Case
  • Reduce cypress execution times.
  • Be more effective in our tests.
Reproduce the error
Related issues

#14103

Suggest a Fix
  • Start every other test from the entity page.
  • Mock backend api when there is no registry in database so tests will be executed instead of skipped.
JHipster Version(s)

main

JHipster configuration
Entity configuration(s) entityName.json files generated in the .jhipster directory
Browsers and Operating System
  • Checking this box is mandatory (this is just to show you read everything)
@pascalgrimaud
Copy link
Member

I'm changing the label, as it's more an improvement than a bug :)

@pascalgrimaud
Copy link
Member

Reading your ticket, one thing which is important, is to be able to execute the test alone. That explains why there are some repetitive steps

@github-actions
Copy link
Contributor

This issue is stale because it has been open 30 days with no activity.
Our core developers tend to be more verbose on denying. If there is no negative comment, possibly this feature will be accepted.
We are accepting PRs 😃.
Comment or this will be closed in 7 days

@github-actions github-actions bot closed this as completed May 5, 2021
@pascalgrimaud pascalgrimaud added this to the 7.1.0 milestone May 28, 2021
@pascalgrimaud pascalgrimaud reopened this Jan 11, 2022
@mshima mshima closed this as completed Apr 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants