From 969fee6cbe2f9d3dbcf9f0b58785d1ed9b759c20 Mon Sep 17 00:00:00 2001 From: Jacob Pratt Date: Tue, 28 Dec 2021 13:51:14 -0500 Subject: [PATCH] Remove FIXME This resolves the concern in favor of prohibiting multiple instances of the attribute. This is similar to non-helper attributes as introduced in #88681. --- compiler/rustc_builtin_macros/src/deriving/default.rs | 3 --- 1 file changed, 3 deletions(-) diff --git a/compiler/rustc_builtin_macros/src/deriving/default.rs b/compiler/rustc_builtin_macros/src/deriving/default.rs index 8c53094b62496..1d1eee88a68e6 100644 --- a/compiler/rustc_builtin_macros/src/deriving/default.rs +++ b/compiler/rustc_builtin_macros/src/deriving/default.rs @@ -222,9 +222,6 @@ fn validate_default_attribute( "this method must only be called with a variant that has a `#[default]` attribute", ), [first, rest @ ..] => { - // FIXME(jhpratt) Do we want to perform this check? It doesn't exist - // for `#[inline]`, `#[non_exhaustive]`, and presumably others. - let suggestion_text = if rest.len() == 1 { "try removing this" } else { "try removing these" };