Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: 전체 리뷰 조회 및 공개 여부 전환에 V2 API 적용 #475

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from
Open

feat: 전체 리뷰 조회 및 공개 여부 전환에 V2 API 적용 #475

wants to merge 5 commits into from
+355 −109

Conversation

scarf005
Copy link
Member

@scarf005 scarf005 commented Jul 7, 2023 •
edited
Loading

개요

2023-08-28_09-43-18.mp4

@tanstack/react-query와 ts-rest를 사용해 전체 리뷰 조회와 리뷰 공개 여부 전환을 리팩터링한 예제입니다.
jiphyeonjeon-42/backend#705

변경점

  • usePatchReviewsId 훅에서 useApi를 client.reviews.patch.useMutation으로 전환했습니다.
  • useGetReviews 훅을 react query를 사용하도록 바꾸었습니다.

참고자료

@scarf005 scarf005 force-pushed the ts-rest branch 4 times, most recently from b473b47 to 8c5cf87 Compare July 8, 2023 06:06
@scarf005 scarf005 marked this pull request as ready for review August 28, 2023 00:48
@scarf005 scarf005 mentioned this pull request Aug 28, 2023
Merged
@scarf005 scarf005 changed the title feat: 리뷰 공개 여부를 ts-rest로 관리 feat: 전체 리뷰 조회 및 공개 여부 전환에 V2 API 적용 Aug 28, 2023
chanhihi
chanhihi approved these changes Oct 23, 2023
View reviewed changes
Copy link
Member

@chanhihi chanhihi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

아~ 완벽히 이해했어!

mink97
mink97 approved these changes Oct 23, 2023
View reviewed changes
Copy link
Contributor

@mink97 mink97 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

아 그런거구나 완벽히 이해했어.(설명 더 해주시면 좋겠습니다.)

@chanhihi chanhihi mentioned this pull request Oct 23, 2023
Open
@scarf005
Copy link
Member Author

설명을 더 보충해오겠습니다!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mink97 mink97 mink97 approved these changes

@chanhihi chanhihi chanhihi approved these changes

@not-using not-using Awaiting requested review from not-using

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

@ts-rest/react-query 적용 zod 추가
3 participants
@scarf005 @chanhihi @mink97