Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support opencensus.io/trace Spans too #9

Closed
jjti opened this issue Jan 9, 2024 · 1 comment
Closed

Support opencensus.io/trace Spans too #9

jjti opened this issue Jan 9, 2024 · 1 comment
Assignees

Comments

@jjti
Copy link
Owner

jjti commented Jan 9, 2024

Describe the solution you'd like
For repos not migrated to OTEL, this linter should also work with the older opencensus spans.

I think it's easy, adding another possible package here (that should be enabled by default):

return ok && obj.Pkg().Path() == "go.opentelemetry.io/otel/trace"

But RecordError does not exist for this type of spans, so we'll want to ignore those in all checks

End() and SetStatus() should be equivalent to otel. RecordError does not exist so should be ignored.

Additional context

https://pkg.go.dev/go.opencensus.io/trace#Span

@jjti jjti self-assigned this Jan 9, 2024
@jjti
Copy link
Owner Author

jjti commented Jan 12, 2024

done on v0.5.0

@jjti jjti closed this as completed Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant