From 0a9f663850aac38a36203660fd9916de3f7ba025 Mon Sep 17 00:00:00 2001 From: Jeremy Lewi Date: Mon, 7 Oct 2024 19:22:28 -0700 Subject: [PATCH 1/3] Trigger test-go on PR * Right now the GHA doesn't trigger for PRs created from forks. * Update the GHA to trigger on pull_request Related to #282 --- .github/workflows/test-go.yaml | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/.github/workflows/test-go.yaml b/.github/workflows/test-go.yaml index c1e75a1f..1d5ead9a 100644 --- a/.github/workflows/test-go.yaml +++ b/.github/workflows/test-go.yaml @@ -1,6 +1,10 @@ # A basic workflow for Go name: test-go -on: [push] +on: + # N.B. If we don't trigger on pull_request then I don't think we trigger the workflow + # on PRs created from forks (e.g. outside contributors). + - push + - pull_request defaults: run: shell: bash -ieo pipefail {0} @@ -28,4 +32,4 @@ jobs: # https://github.com/golangci/golangci-lint-action/issues/244 skip-pkg-cache: true skip-build-cache: true - working-directory: app \ No newline at end of file + working-directory: app From b15681bc733e53134250b508db38d7829cedecfa Mon Sep 17 00:00:00 2001 From: Jeremy Lewi Date: Mon, 7 Oct 2024 19:23:15 -0700 Subject: [PATCH 2/3] Update test-go.yaml --- .github/workflows/test-go.yaml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/.github/workflows/test-go.yaml b/.github/workflows/test-go.yaml index 1d5ead9a..a8eb0e68 100644 --- a/.github/workflows/test-go.yaml +++ b/.github/workflows/test-go.yaml @@ -2,8 +2,7 @@ name: test-go on: # N.B. If we don't trigger on pull_request then I don't think we trigger the workflow - # on PRs created from forks (e.g. outside contributors). - - push + # on PRs created from forks (e.g. outside contributors). - pull_request defaults: run: From 9e688126ff0f6c3827641f7db49330ddc089824a Mon Sep 17 00:00:00 2001 From: Jeremy Lewi Date: Mon, 7 Oct 2024 19:23:38 -0700 Subject: [PATCH 3/3] Update test-go.yaml --- .github/workflows/test-go.yaml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/test-go.yaml b/.github/workflows/test-go.yaml index a8eb0e68..ebb2da06 100644 --- a/.github/workflows/test-go.yaml +++ b/.github/workflows/test-go.yaml @@ -2,7 +2,8 @@ name: test-go on: # N.B. If we don't trigger on pull_request then I don't think we trigger the workflow - # on PRs created from forks (e.g. outside contributors). + # on PRs created from forks (e.g. outside contributors). If we trigger on push then we + # will end up running the workflow twice. - pull_request defaults: run: