Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Roadmap for Econometrics.jl #31

Open
Nosferican opened this issue Sep 12, 2019 · 2 comments
Open

Roadmap for Econometrics.jl #31

Nosferican opened this issue Sep 12, 2019 · 2 comments

Comments

@Nosferican
Copy link

I wanted to get some feedback and thoughts on how best port the information I give for the estimators in Econometrics.jl (see examples). These models cover the ones supported by FixedEffectsModels (e.g., instrumental variables, absorption of features, robust variance covariance estimators) as well as some of the nonlinear models in GLM.jl (e.g., discrete choice models). Would it be best to work on implementing the API?

@jmboehm
Copy link
Owner

jmboehm commented Sep 12, 2019

I think a TableRegressionModel is a good interface for nonlinear model estimates. If you want to show more statistics, we can probably add them in the footer of the table through the regression_statistics option.

@Nosferican
Copy link
Author

Any reason why the API should be at TableRegressionModel?

struct TableRegressionModel{M,T} <: RegressionModel
    model::M
    mf::ModelFrame
    mm::ModelMatrix{T}
end

Those structs don't play that nicely with instrumental variables, not a single ModelFrame/ModelMatrix which are legacy as the new recommended method is modelcols.
Is there any advantage to that over the CoefTable which is part of the API? TableRegressionModel is at StatsModels and technically not part of the abstraction for RegressionModel?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants