Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor ingested data metrics #547

Open
zhuoyuan-liu opened this issue Oct 24, 2024 · 1 comment
Open

Refactor ingested data metrics #547

zhuoyuan-liu opened this issue Oct 24, 2024 · 1 comment
Assignees
Labels
📊 metrics Metrics related issues osctrl-tls osctrl-tls related changes

Comments

@zhuoyuan-liu
Copy link
Contributor

During our test, we found that the osctrl logs the size of each successful request to the database. I would suggest switching to Prometheus metrics with a good overview and much less operational costs.

If we want to keep the current mode that we log every request with the environment and device id, I would suggest moving this to each of the log plugins. This is because some of the users may not want to use the same database to store the query results and these statistical logs. It also reduces the write request to the main/shared database.

@javuto javuto self-assigned this Oct 28, 2024
@javuto javuto added osctrl-tls osctrl-tls related changes 📊 metrics Metrics related issues labels Oct 28, 2024
@javuto
Copy link
Collaborator

javuto commented Oct 28, 2024

I think it makes total sense to track that using Prometheus, which can inspect the received request via its middleware, and without any impact to the backend with read or writes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📊 metrics Metrics related issues osctrl-tls osctrl-tls related changes
Projects
None yet
Development

No branches or pull requests

2 participants