From 9ae7c96de5a059165519fd0707786687bfbe489e Mon Sep 17 00:00:00 2001 From: Antoine Toulme Date: Wed, 25 Oct 2023 16:50:14 -0700 Subject: [PATCH] [chore] Fix a data race in the tests of healthcheckextension (#28629) Fixes #21401 --- .../healthcheckextension_test.go | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/extension/healthcheckextension/healthcheckextension_test.go b/extension/healthcheckextension/healthcheckextension_test.go index e501bb943a8a..ee2298714df4 100644 --- a/extension/healthcheckextension/healthcheckextension_test.go +++ b/extension/healthcheckextension/healthcheckextension_test.go @@ -196,6 +196,8 @@ func TestHealthCheckExtensionUsage(t *testing.T) { }, { step: func(hcExt *healthCheckExtension) error { + hcExt.exporter.mu.Lock() + defer hcExt.exporter.mu.Unlock() hcExt.exporter.exporterFailureQueue = append(hcExt.exporter.exporterFailureQueue, viewData()) return hcExt.Ready() }, @@ -207,6 +209,8 @@ func TestHealthCheckExtensionUsage(t *testing.T) { }, { step: func(hcExt *healthCheckExtension) error { + hcExt.exporter.mu.Lock() + defer hcExt.exporter.mu.Unlock() hcExt.exporter.exporterFailureQueue = append(hcExt.exporter.exporterFailureQueue, viewData()) return hcExt.Ready() }, @@ -233,6 +237,8 @@ func TestHealthCheckExtensionUsage(t *testing.T) { }, { step: func(hcExt *healthCheckExtension) error { + hcExt.exporter.mu.Lock() + defer hcExt.exporter.mu.Unlock() hcExt.exporter.exporterFailureQueue = append(hcExt.exporter.exporterFailureQueue, viewData()) return hcExt.Ready() }, @@ -244,6 +250,8 @@ func TestHealthCheckExtensionUsage(t *testing.T) { }, { step: func(hcExt *healthCheckExtension) error { + hcExt.exporter.mu.Lock() + defer hcExt.exporter.mu.Unlock() hcExt.exporter.exporterFailureQueue = append(hcExt.exporter.exporterFailureQueue, viewData()) return hcExt.Ready() }, @@ -272,6 +280,8 @@ func TestHealthCheckExtensionUsage(t *testing.T) { }, { step: func(hcExt *healthCheckExtension) error { + hcExt.exporter.mu.Lock() + defer hcExt.exporter.mu.Unlock() hcExt.exporter.exporterFailureQueue = append(hcExt.exporter.exporterFailureQueue, viewData()) return hcExt.Ready() }, @@ -285,6 +295,8 @@ func TestHealthCheckExtensionUsage(t *testing.T) { }, { step: func(hcExt *healthCheckExtension) error { + hcExt.exporter.mu.Lock() + defer hcExt.exporter.mu.Unlock() hcExt.exporter.exporterFailureQueue = append(hcExt.exporter.exporterFailureQueue, viewData()) return hcExt.Ready() },