Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Workflows #238

Closed
wants to merge 84 commits into from
Closed

Improve Workflows #238

wants to merge 84 commits into from

Conversation

jmuelbert
Copy link
Owner

Description

Related Issues / Pull Requests

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate)

Checklist

  • If the key of a setting is changed, the old attribute is updated or it is resolved in SettingsUpdater.
  • If needed, I have opened a pull request or an issue to update the documentation.
  • If these changes are notable, they are documented in CHANGELOG.md.

Additional text

@github-actions
Copy link

github-actions bot commented Oct 29, 2023

🦙 MegaLinter status: ❌ ERROR

Descriptor Linter Files Fixed Errors Elapsed time
❌ ACTION actionlint 28 14 0.09s
❌ COPYPASTE jscpd yes 3 1.61s
❌ EDITORCONFIG editorconfig-checker 145 1 0.53s
✅ JSON eslint-plugin-jsonc 18 0 0 0.87s
✅ JSON jsonlint 18 0 0.77s
✅ JSON prettier 18 4 0 3.37s
✅ JSON v8r 17 0 10.09s
⚠️ MARKDOWN markdownlint 10 8 7 1.06s
❌ MARKDOWN markdown-link-check 12 2 9.54s
✅ MARKDOWN markdown-table-formatter 12 10 0 0.29s
❌ REPOSITORY checkov yes 13 13.11s
❌ REPOSITORY gitleaks yes 1 3.45s
✅ REPOSITORY git_diff yes no 0.03s
✅ REPOSITORY grype yes no 17.73s
✅ REPOSITORY secretlint yes no 1.25s
✅ REPOSITORY trivy yes no 3.82s
✅ REPOSITORY trivy-sbom yes no 1.41s
✅ REPOSITORY trufflehog yes no 6.19s
❌ SPELL cspell 155 1110 72.79s
❌ SPELL lychee 53 36 1.24s
⚠️ YAML prettier 49 15 1 5.53s
❌ YAML v8r 49 1 58.05s
❌ YAML yamllint 48 1 2.65s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by OX Security

Copy link

github-actions bot commented Nov 1, 2023

🦙 MegaLinter status: ❌ ERROR

Descriptor Linter Files Fixed Errors Elapsed time
❌ ACTION actionlint 27 1 0.09s
✅ COPYPASTE jscpd yes no 2.39s
❌ EDITORCONFIG editorconfig-checker 139 1 0.73s
✅ JSON eslint-plugin-jsonc 18 0 0 0.98s
✅ JSON jsonlint 18 0 0.2s
✅ JSON prettier 18 2 0 0.86s
✅ JSON v8r 15 0 22.22s
⚠️ MARKDOWN markdownlint 15 6 9 1.82s
❌ MARKDOWN markdown-link-check 17 4 30.23s
✅ MARKDOWN markdown-table-formatter 17 9 0 0.63s
❌ REPOSITORY checkov yes 2 16.25s
❌ REPOSITORY devskim yes 8 2.69s
✅ REPOSITORY dustilock yes no 0.52s
❌ REPOSITORY gitleaks yes 1 13.34s
✅ REPOSITORY git_diff yes no 0.03s
✅ REPOSITORY grype yes no 15.54s
❌ REPOSITORY kics yes 1 33.8s
✅ REPOSITORY secretlint yes no 1.06s
✅ REPOSITORY syft yes no 0.62s
✅ REPOSITORY trivy yes no 5.46s
✅ REPOSITORY trivy-sbom yes no 5.55s
✅ REPOSITORY trufflehog yes no 9.51s
❌ RUBY rubocop 1 1 1 3.5s
❌ SPELL cspell 149 311 29.79s
❌ SPELL lychee 66 674 91.26s
❌ SWIFT swiftlint yes yes 1 44.79s
❌ TYPESCRIPT eslint 4 0 4 5.92s
❌ TYPESCRIPT ts-standard 4 3 1 5.08s
⚠️ YAML prettier 48 8 1 2.74s
❌ YAML v8r 48 1 120.41s
❌ YAML yamllint 48 1 2.1s

See detailed report in MegaLinter reports

You could have the same capabilities but better runtime performances if you use a MegaLinter flavor:

MegaLinter is graciously provided by OX Security


// Files can’t contain further files or directories, so skip iterating children.
return SKIP;
});
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

space indentation expected

node.children = [treeEntry, ...otherChildren];

// Files can’t contain further files or directories, so skip iterating children.
return SKIP;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

space indentation expected


node.children = [treeEntry, ...otherChildren];

// Files can’t contain further files or directories, so skip iterating children.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

space indentation expected

);

if (isDirectory) {
node.children = [
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

space indentation expected

comment.length > 0 ? h('span', {class: 'comment'}, ...comment) : Text()
);

if (isDirectory) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

space indentation expected

node.properties['data-filetype'] = fileExtension;

const treeEntry = h(
'span',
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

' should be "
space indentation expected

if (isPlaceholder) node.properties.class += ' empty';
node.properties['data-filetype'] = fileExtension;

const treeEntry = h(
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

space indentation expected


node.properties.class = isDirectory ? 'directory' : 'file';
if (isPlaceholder) node.properties.class += ' empty';
node.properties['data-filetype'] = fileExtension;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

' should be "
space indentation expected

}

node.properties.class = isDirectory ? 'directory' : 'file';
if (isPlaceholder) node.properties.class += ' empty';
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

' should be "
if statements must be braced
space indentation expected

icon.children.unshift(h('span', {class: 'sr-only'}, directoryLabel));
}

node.properties.class = isDirectory ? 'directory' : 'file';
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

' should be "
space indentation expected

// Use XCTAssert and related functions to verify your tests produce the correct results.
// Any test you write for XCTest can be annotated as throws and async.
// Mark your test throws to produce an unexpected failure when your test encounters an uncaught error.
// Mark your test async to allow awaiting for asynchronous code to complete. Check the results with assertions afterwards.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line Length Violation: Line should be 120 characters or less: currently 126 characters (line_length)

// In UI tests it is usually best to stop immediately when a failure occurs.
continueAfterFailure = false

// In UI tests it’s important to set the initial state - such as interface orientation - required for your tests before they run. The setUp method is a good place to do this.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line Length Violation: Line should be 120 characters or less: currently 178 characters (line_length)

return CONTINUE;
}

node.children = [treeEntry, ...otherChildren];
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

space indentation expected

];
// Continue down the tree.
return CONTINUE;
}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

space indentation expected

]),
];
// Continue down the tree.
return CONTINUE;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

space indentation expected

h('span', {class: isHighlighted ? 'highlight' : ''}, [
isPlaceholder ? null : icon,
firstChild,
]),
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

space indentation expected

{class: 'tree-entry'},
h('span', {class: isHighlighted ? 'highlight' : ''}, [
isPlaceholder ? null : icon,
firstChild,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

space indentation expected

if (!icon.properties) icon.properties = {};
if (isDirectory) {
icon.children.unshift(h('span', {class: 'sr-only'}, directoryLabel));
}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

space indentation expected

const icon = h('span', isDirectory ? FolderIcon : FileIcon(firstChildTextContent));
if (!icon.properties) icon.properties = {};
if (isDirectory) {
icon.children.unshift(h('span', {class: 'sr-only'}, directoryLabel));
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

' should be "
space indentation expected


const icon = h('span', isDirectory ? FolderIcon : FileIcon(firstChildTextContent));
if (!icon.properties) icon.properties = {};
if (isDirectory) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

space indentation expected

Copy link

Please reopen this pull request once you commit the changes requested or make improvements on the code. If this is not the case and you need some help, feel free to seek help from our Gitter or ping one of the reviewers. Thank you for your contributions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant