-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Workflows #238
Improve Workflows #238
Conversation
🦙 MegaLinter status: ❌ ERROR
See detailed report in MegaLinter reports |
🦙 MegaLinter status: ❌ ERROR
See detailed report in MegaLinter reports You could have the same capabilities but better runtime performances if you use a MegaLinter flavor:
|
|
||
// Files can’t contain further files or directories, so skip iterating children. | ||
return SKIP; | ||
}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
space indentation expected
node.children = [treeEntry, ...otherChildren]; | ||
|
||
// Files can’t contain further files or directories, so skip iterating children. | ||
return SKIP; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
space indentation expected
|
||
node.children = [treeEntry, ...otherChildren]; | ||
|
||
// Files can’t contain further files or directories, so skip iterating children. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
space indentation expected
); | ||
|
||
if (isDirectory) { | ||
node.children = [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
space indentation expected
comment.length > 0 ? h('span', {class: 'comment'}, ...comment) : Text() | ||
); | ||
|
||
if (isDirectory) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
space indentation expected
node.properties['data-filetype'] = fileExtension; | ||
|
||
const treeEntry = h( | ||
'span', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
' should be "
space indentation expected
if (isPlaceholder) node.properties.class += ' empty'; | ||
node.properties['data-filetype'] = fileExtension; | ||
|
||
const treeEntry = h( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
space indentation expected
|
||
node.properties.class = isDirectory ? 'directory' : 'file'; | ||
if (isPlaceholder) node.properties.class += ' empty'; | ||
node.properties['data-filetype'] = fileExtension; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
' should be "
space indentation expected
} | ||
|
||
node.properties.class = isDirectory ? 'directory' : 'file'; | ||
if (isPlaceholder) node.properties.class += ' empty'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
' should be "
if statements must be braced
space indentation expected
icon.children.unshift(h('span', {class: 'sr-only'}, directoryLabel)); | ||
} | ||
|
||
node.properties.class = isDirectory ? 'directory' : 'file'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
' should be "
space indentation expected
// Use XCTAssert and related functions to verify your tests produce the correct results. | ||
// Any test you write for XCTest can be annotated as throws and async. | ||
// Mark your test throws to produce an unexpected failure when your test encounters an uncaught error. | ||
// Mark your test async to allow awaiting for asynchronous code to complete. Check the results with assertions afterwards. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line Length Violation: Line should be 120 characters or less: currently 126 characters (line_length)
// In UI tests it is usually best to stop immediately when a failure occurs. | ||
continueAfterFailure = false | ||
|
||
// In UI tests it’s important to set the initial state - such as interface orientation - required for your tests before they run. The setUp method is a good place to do this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line Length Violation: Line should be 120 characters or less: currently 178 characters (line_length)
return CONTINUE; | ||
} | ||
|
||
node.children = [treeEntry, ...otherChildren]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
space indentation expected
]; | ||
// Continue down the tree. | ||
return CONTINUE; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
space indentation expected
]), | ||
]; | ||
// Continue down the tree. | ||
return CONTINUE; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
space indentation expected
h('span', {class: isHighlighted ? 'highlight' : ''}, [ | ||
isPlaceholder ? null : icon, | ||
firstChild, | ||
]), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
space indentation expected
{class: 'tree-entry'}, | ||
h('span', {class: isHighlighted ? 'highlight' : ''}, [ | ||
isPlaceholder ? null : icon, | ||
firstChild, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
space indentation expected
if (!icon.properties) icon.properties = {}; | ||
if (isDirectory) { | ||
icon.children.unshift(h('span', {class: 'sr-only'}, directoryLabel)); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
space indentation expected
const icon = h('span', isDirectory ? FolderIcon : FileIcon(firstChildTextContent)); | ||
if (!icon.properties) icon.properties = {}; | ||
if (isDirectory) { | ||
icon.children.unshift(h('span', {class: 'sr-only'}, directoryLabel)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
' should be "
space indentation expected
|
||
const icon = h('span', isDirectory ? FolderIcon : FileIcon(firstChildTextContent)); | ||
if (!icon.properties) icon.properties = {}; | ||
if (isDirectory) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
space indentation expected
Please reopen this pull request once you commit the changes requested or make improvements on the code. If this is not the case and you need some help, feel free to seek help from our Gitter or ping one of the reviewers. Thank you for your contributions! |
Description
Related Issues / Pull Requests
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate)
Checklist
old
attribute is updated or it is resolved in SettingsUpdater.Additional text