Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove wait_for_ice_gathering_complete #192

Open
johanhelsing opened this issue Mar 31, 2023 · 0 comments
Open

Remove wait_for_ice_gathering_complete #192

johanhelsing opened this issue Mar 31, 2023 · 0 comments
Labels
enhancement New feature or request wasm Only relevant for the wasm implementation

Comments

@johanhelsing
Copy link
Owner

johanhelsing commented Mar 31, 2023

We are waiting for ice gathering completion before we start ice trickling. In theory, this should not be needed, and it's probably slowing down connection times on wasm, especially if the socket is configured with multiple stun servers. However, last I checked, if we removed the wait, nat hole punching started failing.

Solve the todo here:

// todo: the point of implementing ice trickle is to avoid this wait...

Care should be taken to make sure that nat hole punching still works after.

@johanhelsing johanhelsing added enhancement New feature or request wasm Only relevant for the wasm implementation labels Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request wasm Only relevant for the wasm implementation
Projects
None yet
Development

No branches or pull requests

1 participant