-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add description to keymaps that are set #6
Comments
Good suggestion. I had not considered adding an integration with Which key but already have a working PoC. Should be solved soon |
@johmsalas just to be clear, you don't need to integrate with the plugin directly both telescope and which key will read the value of the |
e.g. vim.keymap.set('n', '<key>', lua_func, {desc = 'this is what I do'}) Both plugins will automatically show |
Had to revert the PR. Will publish it soon, will need a test environment without which key. will setup a docker for this |
I left a comment in the old pull request about why you were seeing the issue. It was an issue with how pcall was being used with whichkey |
Hi @johmsalas,
Great work on this plugin, really enjoying using it so far 👍🏿
One very small thing I noticed was that the plugin sets a bunch of keymaps but doesn't set a
desc
on them, this is becoming increasingly useful as plugins liketelescope
andwhichkey
use this value to show readable descriptions for mappings. For any user of those or other plugins using this key, it would be really useful to get a description when setting the keymap so that it's clearer what can be doneWhichkey
Telescope
The text was updated successfully, but these errors were encountered: