-
-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use NPM to build JavaScript dependencies #460
Comments
After that will it be possible to turn the source into a .deb package with a single command, which is possible right now? |
We can still bundle pre-built files, and the package maintainers can choose to build them themselves if they want. |
Will this remove all blockers to enable distribution maintainers to make reproducible builds for Foliate? |
It depends on what you mean by "reproducible". AFAIK the building process is -- and has always been -- already entirely deterministic and reproducible, though I haven't really tested it. However, since the JavaScript libraries are themselves generated from another source, some people consider them to be akin to pre-compiled binaries. This is especially the case with minified files, and literally the case with WebAssembly. In that sense, then, yes, this will make Foliate more "reproducible". |
Currently all JavaScript dependencies are pre-built and bundled. It'd be better if there's an option to use NPM to build everything from source.
The text was updated successfully, but these errors were encountered: