SwiftPM : Resolve apparent version incompatibility with swift-snapshot-testing

[ghost]

• I've searched other open/closed issues for duplicates before opening up this new issue.

Report

What did you do?

1. I cloned the Down repository.
2. From the root of the directory of this cloned repository, I opened the workspace by issuing this command: xed .
3. I attempted to build the project.

What did you expect to happen?

For an iOS device target, I expected the library to build (Cmd-B) and/or test (Cmd-U) successfully.

What happened instead?

The Build attempt failed, with the following error:

No such module 'SnapshotTesting'

This impacts both StylerTestSuite.swift & VisitorTests, which include:

import SnapshotTesting

Additional context

• The preceding steps do work if I execute them against a branch created from the previous tag (i.e., v0.8.6).
• It appears that the SnapshotTesting dependency was recently introduced.
• I intended to submit a pull request proposing changes to Package.swift that account for this dependency, but incompatibilities exist between the minimum required deployment targets of each component (see below).

Platform	Down	SnapshotTesting
iOS	9.0	10.0
macOS	10.11	10.10
tvOS	9.0	10.0

Questions

1. This was surfaced in [Testing] Adding a snapshot testing framework #165, but the impact to SwiftPM support might not have been considered at that time. Does the value of these snapshot tests justify upgrades to the minimum deployment target for iOS & tvOS?
2. Is it there a more limited scope with which the package dependency can be imported in Package.swift?

[iwasrobbed]

@stevebaranski I'd be okay with bumping support to iOS 10+ and will happily accept any PRs against that if you have the time to test and make sure it resolves it for you. Anyone needing support for earlier OS versions can easily do so

[iwasrobbed]

Thanks for the very detailed issue by the way, it's refreshing 💯

[ghost]

@iwasrobbed Upon further investigation, I noted that some of the files specified in the testTarget of Package.swift included those that imported SnapshotTesting. Excluding those files appeased SwiftPM, without requiring an update to the minimum deployment targets.

I expressed #203 for your consideration.

Thanks for the very detailed issue by the way

No problem - thanks for your continued stewardship of Down!

[iwasrobbed]

Closed via #203