Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CodeCoverage] Improve accuracy for combined code coverage reporting #205

Closed
iwasrobbed opened this issue Mar 3, 2020 · 0 comments · Fixed by #251
Closed

[CodeCoverage] Improve accuracy for combined code coverage reporting #205

iwasrobbed opened this issue Mar 3, 2020 · 0 comments · Fixed by #251
Labels
enhancement testing Issues related to tests

Comments

@iwasrobbed
Copy link
Collaborator

Issue

Currently we have two different sets of tests that run:

  • Snapshot tests that capture UI for the attributed string tests
  • Unit tests that run against the core functionality (not just attributed strings)

Combined, these two test bundles cover a large % of the project, but that is not being accurately reported right now.

Suggested Solution

We need to ensure CodeCov is combining the code coverages correctly during PR reports. They say they do this automatically, but that doesn't seem to be true.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement testing Issues related to tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Chore] Fix codecov report johnxnguyen/Down
1 participant
@iwasrobbed