Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Building for tvOS fails #49

Closed
128keaton opened this issue Oct 4, 2017 · 3 comments
Closed

Building for tvOS fails #49

128keaton opened this issue Oct 4, 2017 · 3 comments
Labels
bug

Comments

@128keaton
Copy link
Collaborator

tvOS doesn't have a WebKit framework, so creating a separate target might be needed.
screen shot 2017-10-04 at 1 17 15 pm
@128keaton 128keaton changed the title Building for tvOS failes Building for tvOS fails Oct 4, 2017
@128keaton 128keaton added the bug label Oct 4, 2017
@alfredctchoi
Copy link

alfredctchoi commented Oct 5, 2017 •
edited
Loading

Getting a similar issue when running carthage update. In the error logs, I get

~/project/Carthage/Checkouts/Down/Source/Views/DownView.swift:9:8: error: no such module 'WebKit'
import WebKit
       ^

@128keaton
Copy link
Collaborator Author

@alfredctchoi you will need to state the platform when running update

@iwasrobbed
Copy link
Collaborator

iwasrobbed commented Oct 21, 2017 •
edited
Loading

Sorry for the slow response; the easiest thing to do might be to just conditionally compile using #if os(tvOS)

I'll push a change with this soon to make DownView unavailable for tvOS.

I also added the tvOS build to run on travis and prevent this from breaking in the future.

@iwasrobbed iwasrobbed mentioned this issue Oct 21, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@iwasrobbed @128keaton @alfredctchoi