-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fidelity Bonds #31
Comments
Was just looking at the Issue list here and noticed this. The API exposes an endpoint to get a timelocked destination, and then you can send funds to it. Maker automatically uses the largest FB utxo that exists in the wallet. Clearly it would need some UI but, given this, I don't think API blocks here, unless I forgot something. |
Wonderful! Thanks for the clarification, Adam! |
I'm interested in adding this feature since I need it. Do you have a workflow in mind? I can think of the following checklist:
|
add when the FB unlocks/expires. also, how about having a "auto renew" function, so that when the FB expires, the wallet automatically opens a new one with the same parameters. |
👍
Guess making this not only possible but easier is a great improvement. Little skeptical of doing something like locking coins automatically. |
There are some design explorations for fidelity bonds in Figma already. Just posting them here for reference. |
Hey @abhiShandy , have you already started working on this?
Points look solid. Point 2 and 4 can be skipped if the user never sees an address in the first place. Advanced mode can of course do it differently, e.g. by displayed the timelocked address - but I would not show a qr code for a timelocked address on any of the screens). What do you think? |
No, I haven't started working on it. I like your idea. Let's keep it simple for the first version and take it from there. However, I think we should give some information about fidelity bonds to new Joinmarket users so that they can increase their chances of generating yield. |
Draft PR open: #307 |
This might also come in handy once it is merged and available via api: Script: Add bond-calculator.py #1254. Adds a nice info about the position relative to other FBs, e.g.
|
@theborakompanioni Let me know if there are other stats you would like to see. |
Thank you! I think it contains all the info a user would want when creating a Fidelity Bond. Is there anything you thought of adding?
Yeah, not totally sure myself. Maybe we try parsing the orderbook html (if available) and recreate the information, but I think there are other and better ways to do it. Let's see. Maybe you have some ideas that'd be less clumsy? |
Add support to lock up funds in a fidelity bond.
As per Adam's comment below, we can use the gettimelockaddress API call to create fidelity bonds.
The text was updated successfully, but these errors were encountered: