fix: do not enable debug features on npm start
#549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dergigi
approved these changes
Oct 26, 2022
| } | ||
|
|
||
| const devMode = process.env.NODE_ENV === 'development' | ||
| const devMode = process.env.NODE_ENV === 'development' && process.env.REACT_APP_JAM_DEV_MODE === 'true' |
| @@ -48,14 +48,15 @@ | |||
| "serve": "14.0.1" | |||
| }, | |||
| "scripts": { | |||
| "dev:start": "REACT_APP_JAM_DEV_MODE=true npm start", | |||
There was a problem hiding this comment.
Nice and simple, I like it 👍
dergigi
added
documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #548.
Before this PR, starting Jam with
npm startenabled debug features.After this PR,
npm startwill behave like if a user built the app withnpm buildand debug features are disabled.This means a developer must switch to using
npm run dev:startin order to enable debug features.If a dev still uses
npm startthe app will behave "as if on mainnet" - debug features are disabled.This is a compromise and making a dev change his behaviour feels better than making an ordinary user start Jam in a different way.