feat: Show jar total amount in detail view

[httpiga]

Closes #517.
I added total balance next to the tab selector so that it will be always visible.

[theborakompanioni]

Hey @httpiga, thanks for your contribution - nice!
There is already a place where the balance is shown if you select individual utxos. Would it make sense to move the total balance to the same position (if no utxo is selected)?

I am asking because there is also a task related to improving the header. See #528.

[editwentyone]

I like the input, edited my screen

[httpiga]

@theborakompanioni thank you for your comment, initially I considered exactly your suggestion, but doing this would show total amount only in "UTXOs" tab, while you won't see it in "Details" tab, so in the end I decided to put the total amount info outside the "UTXOs" tab content.
I really like @editwentyone design, what do you think if we merge it with my consideration (assuming you agree with this) and we put total amount info below jar name?

[theborakompanioni]

I really like @editwentyone design, what do you think if we merge it with my consideration (assuming you agree with this) and we put total amount info below jar name?

👍 from me!

ping @editwentyone

[editwentyone]

@httpiga I would like to keep the header clean, the total amount is now under "details" and "utxos" visible

please check the Figma file, you can have a better understanding where we are heading: link

[httpiga]

Thank for sharing the Figma with me @editwentyone , I really like the new design!
However, in your design I can't find the total amount in "Details" tab: you have the total for "External Addresses for deposits", but what if the amount is split between external and internal addresses? In this case I can't see the total amount of that jar, am I missing something?

[editwentyone]

hm you are right, its not including the internal ones. will need to rethink it a little bit more, thanks for the hint

[httpiga]

Do you think that's better pausing this PR while waiting for an updated design, or merge this just to have it and refactor later?

[theborakompanioni]

Do you think that's better pausing this PR while waiting for an updated design, or merge this just to have it and refactor later?

Would you be okay with moving it to the place the current figma files suggest, i.e. having it only on the "Jar" tab for now, and then adding it to "Details" tab in a follow-up PR?

I think it is fine either way, we can also merge it now if you prefer that!

[httpiga]

Okay, next week I'm going to move the total amount to the "UTXOs" tab like the Figma suggest!

[theborakompanioni]

Okay, next week I'm going to move the total amount to the "UTXOs" tab like the Figma suggest!

Hey @httpiga, still motivated to get this feature in? 🧡

[httpiga]

Hey @httpiga, still motivated to get this feature in? 🧡

Hey, sorry for having disappeared but had un unexpected busy period - I'll be glad to implement this as soon as I can!

[theborakompanioni]

Hey, sorry for having disappeared but had un unexpected busy period - I'll be glad to implement this as soon as I can!

Don't worry. Glad you are still interested. Please know, that there is absolutely no urgency involved. Take your time!

[httpiga]

Thank you for your patience, what about this?

Bitcoin amount is not bold since the font weight in BalanceComponent is forced at 400 by slashed-zeroes class name, which is used also by other components. Do we want to refactor BalanceComponent to use Bootstrap classes?

[theborakompanioni]

Thank you for your patience, what about this?

Nice! 🧡

Bitcoin amount is not bold since the font weight in BalanceComponent is forced at 400 by slashed-zeroes class name, which is used also by other components. Do we want to refactor BalanceComponent to use Bootstrap classes?

What do you think about merging it and doing the refactoring in a follow-up PR?
Of course, only if you are motivated to do so!

[httpiga]

Let's do this 🧡
I opened this PR to review, and will merge it once approved!