-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Consistent use of walletName
vs walletFileName
#640
Comments
Blocked by #621 |
Idea: When this is consistently done, Jam could store meta information in the filename, e.g. wallet birthday ( |
Various metadata could be stored in wallet .jmdat file itself by JM code. |
Thanks @kristapsk! Let's focus on more important things first! |
It is not totally clear, when a wallet name is needed, if the filename (including extension
.jmdat
) or the "display name" (without extension) is needed. Hence, everytime the wallet name is rendered, it is first given to util functiondisplayWalletName
. This can be made more obvious and the wallet filename, as well as the wallet "display name" should be made statically available in theWalletContext
.Hint: There is already a type
Api.WalletName
which actually means the "wallet filename". Change/introduce types to make this more obvious.The text was updated successfully, but these errors were encountered: