Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Consistent use of walletName vs walletFileName #640

Closed
theborakompanioni opened this issue Aug 18, 2023 · 4 comments · Fixed by #671
Closed

refactor: Consistent use of walletName vs walletFileName #640

theborakompanioni opened this issue Aug 18, 2023 · 4 comments · Fixed by #671
Assignees
Labels
refactoring Code refactoring without functional changes tech dept Removes some technical debt

Comments

@theborakompanioni
Copy link
Collaborator

It is not totally clear, when a wallet name is needed, if the filename (including extension .jmdat) or the "display name" (without extension) is needed. Hence, everytime the wallet name is rendered, it is first given to util function displayWalletName. This can be made more obvious and the wallet filename, as well as the wallet "display name" should be made statically available in the WalletContext.

Hint: There is already a type Api.WalletName which actually means the "wallet filename". Change/introduce types to make this more obvious.

@theborakompanioni theborakompanioni added tech dept Removes some technical debt refactoring Code refactoring without functional changes labels Aug 18, 2023
@theborakompanioni theborakompanioni self-assigned this Aug 18, 2023
@theborakompanioni
Copy link
Collaborator Author

Blocked by #621

@theborakompanioni theborakompanioni added the blocked Merging this pull request is blocked until another issue is resolved label Aug 24, 2023
@theborakompanioni theborakompanioni added this to the v0.1.6 - TBD milestone Aug 24, 2023
@theborakompanioni
Copy link
Collaborator Author

theborakompanioni commented Sep 3, 2023

Idea: When this is consistently done, Jam could store meta information in the filename, e.g. wallet birthday (jam_<wallet_name>_20090103.jmdat). This might be one way for Jam to store some info about the wallet permanently.

@theborakompanioni theborakompanioni removed the blocked Merging this pull request is blocked until another issue is resolved label Oct 4, 2023
@kristapsk
Copy link
Contributor

Idea: When this is consistently done, Jam could store meta information in the filename, e.g. wallet birthday (jam_<wallet_name>_20090103.jmdat). This might be one way for Jam to store some info about the wallet permanently.

Various metadata could be stored in wallet .jmdat file itself by JM code.

@theborakompanioni
Copy link
Collaborator Author

theborakompanioni commented Oct 8, 2023

Idea: When this is consistently done, Jam could store meta information in the filename, e.g. wallet birthday (jam_<wallet_name>_20090103.jmdat). This might be one way for Jam to store some info about the wallet permanently.

Various metadata could be stored in wallet .jmdat file itself by JM code.

Thanks @kristapsk!
It was a very stupid thought of mine. 😬

Let's focus on more important things first!
(e.g. access to blocks (blockheight) would be a nice-to-have for Jam - will open a ticket).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Code refactoring without functional changes tech dept Removes some technical debt
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants