Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add message to Jar Details View if operations are disabled #856

Closed
theborakompanioni opened this issue Oct 8, 2024 · 4 comments · Fixed by #869
Closed

Add message to Jar Details View if operations are disabled #856

theborakompanioni opened this issue Oct 8, 2024 · 4 comments · Fixed by #869
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers
Milestone

Comments

@theborakompanioni
Copy link
Collaborator

When a maker or taker operation is running, the freeze/unfreeze buttons do not appear in the Jar Details View.
Currently, a user might be confused that the buttons are not displayed.
Add a message that explains why freezing/unfreezing is currently not possible.

@theborakompanioni theborakompanioni added enhancement New feature or request good first issue Good for newcomers labels Oct 8, 2024
@editwentyone editwentyone added this to the v0.4.0 milestone Oct 26, 2024
@nischal-shetty2
Copy link
Contributor

hey @theborakompanioni would love to work on this, what should the message be and how/where should it be displayed? @editwentyone

@theborakompanioni
Copy link
Collaborator Author

Hey @nischal-shetty2! Great to her! 🙏

I think displaying a text that just says "A maker/taker operation is in progress. Some operations are disabled." is okay. It can be shown right where the buttons would have been. What do you think? Optionally add an info icon that the user can click/hover to get more information.

Also, what about still displaying the buttons but disable them? They do not really look pretty at the moment.. a visual update is highly welcome.

@nischal-shetty2
Copy link
Contributor

It can be shown right where the buttons would have been. What do you think?

Yes, I agree. Displaying it above the buttons could work well.

what about still displaying the buttons but disable them? They do not really look pretty at the moment.. a visual update is highly welcome.

I think that’s a great idea—it would help prevent any confusion about where the buttons disappeared. For updating the button visuals, I’d love to hear any suggestions if you have ideas! @theborakompanioni @editwentyone

Optionally add an info icon that the user can click/hover to get more information.

What do you think about displaying A maker/taker operation is in progress. Some operations are disabled. right next to the info icon by default? This way, users get the context without needing extra effort. Here’s an example of what I mean with the note on this page:

Screenshot 2024-11-05 at 9 59 15 PM

In the meantime, I'll start coding up these changes.

@theborakompanioni
Copy link
Collaborator Author

What do you think about displaying A maker/taker operation is in progress. Some operations are disabled. right next to the info icon by default? This way, users get the context without needing extra effort.

Perfect 👌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants