Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

alternative entropy method #1294

Closed
chunningham opened this issue May 6, 2019 · 4 comments
Closed

alternative entropy method #1294

chunningham opened this issue May 6, 2019 · 4 comments

Comments

@chunningham
Copy link
Contributor

What is the scope of the feature
A better method for generating entropy (easier for the user/more secure)

Additional important information
hardware based is better, ideally without user input

@chunningham
Copy link
Contributor Author

@mnzaki
Copy link
Contributor

mnzaki commented May 7, 2019

https://github.com/mvayngrib/react-native-randombytes is kinda wonky.
It uses callbacks and not promises (so needs awkward wrapping) and adds an extra unnecessary dependency on https://github.com/bitwiseshiftleft/sjcl which it falls back to if you use the sync API (calling it without a callback param)

So, I suggest this instead: https://github.com/rh389/react-native-securerandom
it's slightly smaller, simpler, and more straightforward

@chunningham
Copy link
Contributor Author

Ah yes, I came across that and had a look. I also preferred it but I thought that maybe randombytes was more established/less at risk of becoming abandonware. I'm happy to use securerandom though

@mnzaki
Copy link
Contributor

mnzaki commented May 8, 2019

Ok so react-native-securerandom has its own set of problems (package is not transpiled, and includes a .babelrc which is messing with our build system, and also the developer is not active). Back to randombytes but I'm going to ignore all their JS code and just add a small util that uses the NativeModule directly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants