Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make SettingsItem based on a 'Touchable' component #1450

Closed
1 task done
saifahn opened this issue Sep 9, 2019 · 0 comments · Fixed by #1451
Closed
1 task done

Make SettingsItem based on a 'Touchable' component #1450

saifahn opened this issue Sep 9, 2019 · 0 comments · Fixed by #1451

Comments

@saifahn
Copy link

saifahn commented Sep 9, 2019

Description

Currently SettingsItem is based on a View component with an action assigned to onTouchEnd. The problem with this is that the touch will register while you are scrolling, and you can accidentally touch a settings item and perform and action you didn't want to. This is especially problematic with the 'Backup my identity' as there is no way to escape this screen on iOS without completing the process or exiting the app.

'Touchable' components such as TouchableOpacity or TouchableWithoutFeedback detect if you are scrolling and do not fire their action in these cases.

Tasks

  • Change View component to Touchable component on SettingsItem component.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant