Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 fix: react-native@0.68.2 always load main.jsbundle instead of thread bundle #158

Open
anasmassnaoui opened this issue Jun 8, 2024 · 2 comments

Comments

@anasmassnaoui
Copy link

anasmassnaoui commented Jun 8, 2024

Hi! 👋

Firstly, thanks for your work on this project! 🙂

Today I used patch-package to patch react-native-threads@0.0.19 for the project I'm working on.

Here is the diff that solved my problem:

diff --git a/node_modules/react-native-threads/ios/ThreadManager.m b/node_modules/react-native-threads/ios/ThreadManager.m
index 3aa1bba..f3b22aa 100644
--- a/node_modules/react-native-threads/ios/ThreadManager.m
+++ b/node_modules/react-native-threads/ios/ThreadManager.m
@@ -19,8 +19,15 @@ @implementation ThreadManager
   }
 
   int threadId = abs(arc4random());
+    NSURL *threadURL = NULL;
+
+  // NSURL *threadURL = [[RCTBundleURLProvider sharedSettings] jsBundleURLForBundleRoot:name fallbackResource:name];
+#if DEBUG
+    threadURL = [[RCTBundleURLProvider sharedSettings] jsBundleURLForBundleRoot:name];
+#else
+    threadURL = [[NSBundle mainBundle] URLForResource:name withExtension:@"jsbundle"];
+#endif
 
-  NSURL *threadURL = [[RCTBundleURLProvider sharedSettings] jsBundleURLForBundleRoot:name fallbackResource:name];
   NSLog(@"starting Thread %@", [threadURL absoluteString]);
 
 

This issue body was partially generated by patch-package.

@Meligy
Copy link

Meligy commented Aug 2, 2024

Hello,

Is this project actually alive?

If not, what's a good alternative today?

Thanks.

@Traviskn
Copy link
Contributor

Traviskn commented Aug 2, 2024

@Meligy Unfortunately this project is not actively maintained. I would recommend react native worklets as an alternative (worklets were pioneered by the react-native-reanimated library) https://github.com/margelo/react-native-worklets-core/blob/main/docs/USAGE.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants