Implement new adapter PickFirst, picking between multiple deserialization options
#291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion options This was originally proposed in #276 under the name `DeserializeOptions`. The adapter takes 2-4 types and tries each in order. The first option which deserializes is returned. The type is still missing documentation.
jonasbb
changed the title
PickFirst, picking between multiple deserialization options
Codecov Report
@@ Coverage Diff @@
## master #291 +/- ##
==========================================
+ Coverage 78.04% 78.29% +0.25%
==========================================
Files 40 41 +1
Lines 2337 2387 +50
==========================================
+ Hits 1824 1869 +45
- Misses 513 518 +5
Continue to review full report at Codecov.
|
|
I'm just gonna merge this with the current name. I rather have this published. bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@pashadia I found some time to implement the
DeserializeOptionsyou proposed in #276.I'm not quite happy with the name yet. I am thinking maybe something along those line:
ChooseChoicesPickFirstThis was originally proposed in #276 under the name
DeserializeOptions.The adapter takes 2-4 types and tries each in order. The first option
which deserializes is returned.
The type is still missing documentation.