- Addition of support of Date::Holidays::CW via Date::Holidays::Adapter::CW via PR #125 by Wesley Schwengle (@waterkip) author of: [Date::Holidays::CW], the calendar implementation for Curaçao
- Merged PR #113 by @haarg. Removing unused explicit imports, where error handling will change in the future, so this is a preemptive change
-
Specified requirement for Test::MockModule as
0.13
, when migrating to use of acpanfile
for dependency specification, I forgot to specify the version even though it was specified in the Dist::Zilla configurationdist.ini
, thanks to @eserte for spotting this. It is actually a regression in that sense that it was also fixed in #47. This addresses #76 -
Added missing adapter Date::Holidays::Adapter::CA for Date::Holidays::CA
-
Commented out some problematic and noisy tests, which require some additional work
-
Further improvement to the handling of the parameters required by:
- Date::Holidays::NL via Date::Holidays::Adapter::NL
- Date::Holidays::AW via Date::Holidays::Adapter::AW
- Date::Holidays::BQ via Date::Holidays::Adapter::BQ
The
gov
andlang
parameters can now be used in conjunction with the country list parameter
-
Introduction of Date::Holidays::Adapter::BQ for adapting Date::Holidays::BQ
-
Support for extra parameters for
is_holiday
andis_holiday_dt
:- Date::Holidays::NL via Date::Holidays::Adapter::NL
- Date::Holidays::AW via Date::Holidays::Adapter::AW
- Date::Holidays::BQ via Date::Holidays::Adapter::BQ
All via PR #70 by Wesley Schwengle (@waterkip) author of:
-
Fixed and clean up to Dist::Zilla configuration by @jonasbn
- Improved support for Date::Holidays::FR
- PR from @qorron #53 fixes issue with initialization of US calendar via the adapter. The official calendar module is called: Date::Holidays::USFederal.
- Added contribution guidelines for meta.cpan.org
- We need to specify the requirement of Test::MockModule to version 0.13, since redefined not introduced until this version
-
Fixed a bug in the mock introduced in release 1.27. Had added it to the
cpanfile
, but not the proper prerequisites and the mocking was not correct syntax -
Made adjustments to the tar-ball generation, way to much non-distribution related material included
- I am implementing an example application and I came across a minor bug in the adapter for Date::Holidays::SK. Reported as issue #45
- Introduced some issues with references and test suite for the new addition Date::Holidays::AW
Thanks to Wesley Schwengle for the PR
-
Added adapter for: Date::Holidays::AW (Aruba)
-
Added adapter for: Date::Holidays::NL (Netherlands)
Thanks to Wesley Schwengle for mentioning his CPAN contributions to the Date::Holidays::* namespace
-
Improvements to Dist::Zilla configuration, only ExtUtils::MakeMaker supported via Dist::Zilla now. Module::Build support having been removed
-
See the article by Neil Bowers (NEILB) on the topic
-
Thanks to Karen Etheridge (ETHER) for information and link to the mentioned article
- Addressed broken support for regions in ES (Spain), improving support for Date::Holidays::CA_ES Thanks to Miquel Ruiz
- Addressed a minor bug in the test suite addressed with release 1.19, Date::Holidays::UA supports a holidays method
- A bug was introduced with the release of 1.19, the bug had been lurking since just after the release of 1.18. The bug did not show itself unless adaptees where installed and I tested release 1.19 on a branch new Perlbrew installation, so the bug was not demonstrated.
-
Added adapter for: Date::Holidays::UA added to the distribution thanks to Denis Boyun
Ref: PR #38
Also fixed a minor bug the documentation, my bumping of the version numbers across the files in the distribution had altered a parameter description. Apparently this had not caught my eye until now.
-
Added adapter for: Date::Holidays::AT(Austria) we now support the state parameter for this distribution
Ref: PR #33
-
Improved adapter for: Date::Holidays::DE we now support the state parameter for this distribution
Ref: PR #31
-
Added adapter for: Date::Holidays::CZ the distribution had some issue with building these issue seems to have been fixed
Ref: PR #30
-
Added implementation of
is_holiday
method for Date::Holidays::DERef: PR #18
-
Changed the structure returned from Date::Holidays::DE from a reference to an array to a reference to a hash, which is easier to work with and seems to be the de facto standard
This is all done in the adapter.
Ref: PR #29
-
Date::Holidays::UK marked as unsupported
-
Date::Holidays::UK::EnglandAndWales marked as unsupported
Ref: PR #11
-
Addressed issue with support for country code UK. This is done with the adapter Date::Holidays::Adapter::UK, which uses Date::Holidays::GB via Date::Holidays::Adapter::GB.
Ref: PR #14
-
This release integrates Date::Holidays::CA_ES is does so by supporting the region parameter with the value 'ca' via Date::Holidays::ES
Ref: PR #28
-
Added adapter for US, an implementation adapting Date::Holidays::USFederal but for the official and standard country code
Ref: PR #27
-
Added adapter for: Date::Holidays::SK the integration had some flaws, which have now been addressed with the new adapter
Ref: PR #23
-
Added adapter for: Date::Holidays::NZ the distribution has been supported for some time, but the latest changes revealed a sub-optimal integration. Support for regions was also added
Ref: PR #22
-
Based on issue #21 several issues with the test suite was spotted and corrected, at the same time there was created issues for implementation of adapters for SK and NZ. An issue with ES was also created since this distribution seems to rely on Date::Holidays, which does not seem to make sense.
Ref: PR #21
- Added adapter for: Date::Holidays::USFederal (US) in response to request from Scott Seller. This required a lot of changes to internal code and the test suite was restructured. I hope I did not break anything, all tests pass currently.
- Added adapter for: Date::Holidays::KZ (Kazakhstan) via patch from Vladimir Varlamov
-
Added use of Test::Fatal
-
Added homepage metadata and changed GitHub URL
-
Added Dist::Zilla plugins requirements causing issues to
dist.ini
, so these are explicitly specified -
Exchanged CJM´s: Dist::Zilla::Plugin::VersionFromModule
For Dave Rolskys: Dist::Zilla::Plugin::VersionFromMainModule
There are some deprecation notices from Dist::Zilla making tests fail see XDG's PR
- Addressed GitHub issue #10 reported by Alexandr Ciornii (CHORNY)
carton
generated directorylocal/
was included in distribution by accident
- Added adapter for: Date::Holidays::BY (Belarus) via patch from Vladimir Varlamov
- Following up on some TODO points in the code, probably in relation to: RT:101366
-
Aligned version numbers in Perl components in
lib/
-
Added missing version in Date::Holidays::Adapter::LOCAL
-
Added
MetaProvides
to Dist::Zilla build, this should assist in addressing the issue listed on CPANTSRef: Date-Holidays-1.01
- Added adapter for: Date::Holidays::RU via patch from Alexander Nalobin
-
License upgraded from Artistic License 1.0 to Artistic License 2.0
-
You can now overwrite calendars with a local file, see issue #6
-
Use of Error has been removed
-
Use of
can
from UNIVERSAL had been changed to more contemporary pattern -
Adapter strategy has also been changed so adapters have precedence over adapted implementations
-
Addressing issue #7
This is bug in the tests suite generating reports on failures from CPAN testers.
-
Added adapter for: Date::Holidays::GB addressing GitHub issue #4
Date::Holidays::GB exposes new parameter: regions, for local countries under GB.
-
Fixed bug in countries parameter handling
-
Fixed bug in Date::Holidays::Adapter::FR, which wrongfully reported lack of implementation of is_holidays method when it was the holidays method - error being thrown upon call to holidays methods
-
Added adapters for: Date::Holidays::CN Date::Holidays::KR Date::Holidays::PL
Addressing GitHub issue #5
-
First shot at improvement of Date::Holidays::Adapter code, this needs more work
-
Improvements to the test suite, this also needs additional work
-
Introducing use of Scalar::Util
- This release addressed reports on failing tests for perl 5.21 The use in this distribution of UNIVERSAL is now deprecated, see: GitHub issue #3 and RT:98337
- Added adapter class for Date::Holidays::BR (RT:63437)
-
Migrated from Module::Build to Dist::Zilla
-
Fixed issue in some test, which would break if Date::Holidays::DK was not installed
-
Fixed POD error
-
Aligned all version numbers
-
Added
t/kwalitee.t
Test::Kwalitee test -
Added
t/changes.t
Test::CPAN::Changes test
-
Added
t/perlcriticrc
-
Updated
t/critic.t
to more contemporary version
-
Added the following (again) to
MANIFEST
as a result of the Kwalitee test:t/pod.t
t/pod-coverage.t
These had been removed from the distribution, but the Kwalitee metrics likes them so, they are however not run as part of the normal test suite unless
$TEST_POD
is set in your environment.
-
Fixed broken tests
t/new.t
did not have aSKIP
sectiont/datetime.t
did not have aSKIP
section
-
Fixed a problem with
pod.t
-
Increased the Perl::Critic severity to
5
-
Exchanged Readonly for good old constants, one less dependency, should make the failing tests go away
-
Added missing requirement to
Build.PL
Readonly Based on tests reports from CPAN testersThanks david at cantrell.org.uk
I thought Readonly was core, but according to Module::CoreList this is not the case, so this has been corrected now
-
Updated to more contemporary versions of:
t/pod-coverage.t
t/pod.t
These should be there for the quality, but will not be run as a part of the normal test run, unless the
$TEST_POD
environment variable is set.This seem to be the de facto way of doing things. So they have been removed from
MANIFEST.SKIP
so they are now a part of the distribution.
-
Updated and corrected POD in Date::Holidays
-
Updated and corrected POD in Date::Holidays::Adapter
-
Added
$VERSION
to all exception classes (Date::Holidays::Exception::*), I and who just file an RT ticket on the same issue for another distributionoh the sweet nemesis :)
-
Updated POD in all exception classes (Date::Holidays::Exception::*)
-
Updated POD in Date::Holidays::Adapter::AU
-
Updated POD in Date::Holidays::Adapter::GB
-
Updated POD in Date::Holidays::Adapter::PT
-
Updated POD in Date::Holidays::Adapter::NO
-
Updated POD in Date::Holidays::Adapter::DK
-
Updated POD in Date::Holidays::Adapter::FR
-
Updated POD in Date::Holidays::Adapter::DE
-
Updated POD in Date::Holidays::Adapter::JP
-
Added new adapter for Date::Holidays::Adapter::ES
lib/Date/Holidays/Adapter/ES.pm
-
Added use of exceptions instead of carp in Date::Holidays::Adapter, this however produces issues with adhering to Perl::Critics recommendation on explicit returns. Be aware that return with in Error's try-catch block returns from a sub, so you have to have a return outside the block.
Perl::Critic is happy and I am happy
Updated version to 0.02 for Date::Holidays::Adapter
-
Added no_indexing of
t/
directory to Build.PL -
Updated README with pod2text appending of Date::Holidays POD
-
Code cleaned a bit, much work still to be done
-
Wrote some better DIAGNOSTICS and added 3 more Exceptions
lib/Date/Holidays/Exception/InvalidCountryCode.pm
lib/Date/Holidays/Exception/NoCountrySpecified.pm
lib/Date/Holidays/Exception/UnsupportedMethod.pm
-
Added a few tests adapters for some of the tests dating before the refactoring (all tests now pass):
t/lib/Date/Holidays/Adapter/NOPOLY.t
t/lib/Date/Holidays/Adapter/OOP.t
-
Renamed
_loader
in Date::Holidays to_fetch
and_load
, see also the similar methods in Date::Holidays::Adapter_loader.t
obsolete and removed -
Introduced use of Error (Exceptions) for better diagnostics:
Date/Holidays/Exception/AdapterInitialization.pm
Date/Holidays/Exception/AdapterLoad.pm
Date/Holidays/Exception/SuperAdapterLoad.pm
-
Refactored the whole thing to a variation of an object adapter pattern, introduced:
lib/Date/Holidays/Adapter.pm lib/Date/Holidays/Adapter/ lib/Date/Holidays/Adapter/AU.pm lib/Date/Holidays/Adapter/DE.pm lib/Date/Holidays/Adapter/DK.pm lib/Date/Holidays/Adapter/FR.pm lib/Date/Holidays/Adapter/GB.pm lib/Date/Holidays/Adapter/JP.pm lib/Date/Holidays/Adapter/NO.pm lib/Date/Holidays/Adapter/PT.pm
tests are located in t/Adapter: _fetch.t _load.t new.t
-
Set severity to 3 for Test::Perl::Critic test ran code through
perltidy
to remove hard tabs -
Set severity to 4 for Test::Perl::Critic test added use warnings statement
-
Changed the constructor to no longer be able to initialize a shallow object. If you want to make use of Date::Holidays ability to check all countries for a given holiday please, use it using full namespace. POD updated correspondingly.
-
Addressed issue with method calling problems, OOP vs. Procedural vs. the weird mix I personally had boiled up, thanks to Florian Merges for reporting this.
This has resulted in a minor cleanup and again I can see that the current architecture is not optimal, I am planning a major rewrite, to eliminate the problems of handling new classes introduced in the Date::Holidays::* namespace.
I am not an authority of any kind, I just attempt to get things to play along nicely.
New files introduced:
t/NOPOLY.t
t/OOP.t
t/SUPERED.t
t/ABSTRACTED.t
t/PRODUCERAL.t
t/new.t
and the test classes (in t/lib/Date/Holidays):
ABSTRACTED.pm
NOPOLY.pm
OOP.pm
PROCUDERAL.pm
SUPERED.pm
-
Updated
MANIFEST.SKIP
with more contemporary version -
Added
t/critic.t
, Test::Perl::Critic test, currently at severity5
. In addition to this I changed the return ofundef
scattered all over the code to simple return statements. -
Added
t/kwalitee.t
, Test::Kwalitee test, disabled check for symlinks since it reacted on symlinked.releaserc
in directory, which however is NOT in the distribution even though it thinks soAdded the following as a result of the Test::Kwalitee test:
t/pod.t
t/pod-coverage.t
-
Added use of Module::Load to
Build.PL
and to own_loader
routine in Date::Holidays. I also added:t/_loader.t
to isolate the actual test
-
Added RT request #21089, helper scripts not part of distribution, but mentioned in the auto-generated
Makefile.PL
Renamed
bin/
directory toscripts/
-
Removed
bin/
directory from distribution (it is development purpose only anyway) -
Removed
t/pod.t
(and prerequisites inBuild.PL
) this test can be performed by Module::Build -
Removed
t/pod-coverage.t
(and prerequisites inBuild.PL
) this test can be performed by Module::Build -
Updated TODO with new point
-
Changed way
Makefile.PL
is generated from 'passthrough' to 'traditional', I kind of like the way it is done in Workflow, so I adapted this -
Fixed a bug in program flow concerning Date::Holidays::DE
-
Fixed a test holding a wrong number of tests to be skipped
-
Updated POD, added Date::Holidays::CN to SEE ALSO section (no work done to implement this at this time
-
Updated POD with TEST COVERAGE section, planning next release to be a maintenance release focused on test coverage
Also in an attempt to address report on failing tests
-
Moved build requirements to special section in
Build.PL
-
Added AU and NZ to
bin/test_date-holidays.t
-
Updated
MANIFEST.SKIP
with:- Komodo project file
- Module::Build parameters mentioned in Module::Signature
-
Signed module using Module::Signature, added:
t/0-signature.t
SIGNATURE
-
Parameter 'state' also added for holidays method, have sent patch to David Dick author of Date::Holidays::AU offering a more flexible API.
-
Added some more POD on developing in the Date::Holidays::* namespace
-
Date::Holidays::AU have been updated to 0.03, meaning that the exception implemented in 0.05 could be removed, it was however changed to accommodate the state parameter implemented in Date::Holidays::AU.
-
Exchanged manually built
Makefile.PL
for aMakefile.PL
maintained by Module::Build
-
Addressing failing test
So we have added yet another exception, this time for Date::Holidays::AU.
The problem is that its method is_holiday, needs an additional parameter indicating the state, the holidays method in the same module defaults to VIC, so for know we are using this as our default state, this will need readdressing.
-
Changes to unit-tests, it was assumed that some of the Date::Holidays modules where installed, this is not always the case
This was pointed out to me by shild on use.perl.org
-
Small refactoring added new sub
_check_countries
-
Moved portuguese exception, Date::Holiday::PT has changed name to Date::Holidays::PT, but it has turned OOP.
-
Implemented new parameter in
is_holiday
(countries). This method returns a list of country codes having the holiday specified as a holiday for the respective country (suggested by cog).So it has to be used in conjunction with the data parameters: year, month and day
if given a subset of countries only these countries are tested and a hashref is returned pointing where the countries codes are the keys and the values indicate true or false for the date specified.
The values are:
undef
if the country has no module or the data could not be obtained- a name of the holiday if a holiday is present
- an empty string if the a module was located but the day is not a holiday
-
Updated
INSTALL
-
Removed Exporter from prerequisites
-
Replaced use of ExtUtils::Makemake with Module::Build
-
Added real names to Changes file (this file)
-
Added suggestion on improvements from cog (Jose Castro) to TODO
-
Indented code in POD after tip from RJBS (Ricardo Signes)
-
'jp' left out of the test suite for now
-
Date::Holidays::NO added to test suite, courtesy of MRAMBERG (Marcus Ramberg)
-
Added experimental subs using DateTime objects as suggested by BORUP (Christian Borup) (SEE: TODO)
- Initial release