Fixed issues: #207 unit tests fails on win due to line breaks, #206 driver/run returns simplify maps with no :file #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
voytech
commented
Feb 9, 2018
voytech
commented
- driver/run was returning simplify maps without :file component present in map. Because of that results from driver/run were not enough informative from perspective of kibit consumers.
- all tests are passing on win. They were not passing because of println and newline producing \r\n on win while on Linux it is just \n
clj-commons#206 - check-file passes simplify-map with file to reporter, but returns simplify-map without a :file entry in map clj-commons#207 - fix unit test failures on Windows
danielcompton
force-pushed
the
master
branch
from
63abd4b to
e068571
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.