From 73cb3b90c33f1a2254b5424912693f4a3bfe1ae2 Mon Sep 17 00:00:00 2001 From: Jonas Raoni Soares da Silva Date: Fri, 25 Aug 2023 17:36:30 +0300 Subject: [PATCH] pkp/pkp-lib#8710 Updated comments --- classes/submission/Collector.php | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/classes/submission/Collector.php b/classes/submission/Collector.php index dbcfcd4f4ae..1003265ebb3 100644 --- a/classes/submission/Collector.php +++ b/classes/submission/Collector.php @@ -517,6 +517,7 @@ public function getQueryBuilder(): Builder ->whereIn('pc.category_id', $this->categoryIds); } + // Filter by is reviewed by if ($this->isReviewedBy !== null) { // TODO consider review round and other criteria; refactor query builder to use ->when $q->when($this->isReviewedBy === self::UNASSIGNED, function (Builder $q) { @@ -527,12 +528,13 @@ public function getQueryBuilder(): Builder } // By any child pub object's DOI status + // Filter by any child pub object's DOI status $q->when($this->doiStatuses !== null, fn (Builder $q) => $this->addDoiStatusFilterToQuery($q)); - // By whether any child pub objects have DOIs assigned + // Filter by whether any child pub objects have DOIs assigned $q->when($this->hasDois !== null, fn (Builder $q) => $this->addHasDoisFilterToQuery($q)); - // By whether any child pub objects have DOIs assigned + // Filter out excluded submission IDs $q->when($this->excludeIds !== null, fn (Builder $q) => $q->whereNotIn('s.submission_id', $this->excludeIds)); // Limit and offset results for pagination