Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2 entries in launch_background.xml #4

Closed
htsnet opened this issue Aug 27, 2019 · 5 comments
Closed

2 entries in launch_background.xml #4

htsnet opened this issue Aug 27, 2019 · 5 comments

Comments

@htsnet
Copy link

htsnet commented Aug 27, 2019

Before I run this package, I already tag in my launch_background.xml file.

After the run, I see 2 item in the file:

@henriquearthur
Copy link
Collaborator

Which tags are duplicated?


This package looks for an android:src="@drawable/splash" attribute, like in the tag:

<bitmap android:gravity="center" android:src="@drawable/splash" />

If it finds this attribute, won't add a new one. But it doesn't search for any other tags - you can add as many tags you want to your launch_background.xml.

@henriquearthur henriquearthur added android waiting response Further information is requested bug Something isn't working and removed waiting response Further information is requested bug Something isn't working labels Aug 27, 2019
@henriquearthur
Copy link
Collaborator

@htsnet can you provide more information to this issue?

@htsnet
Copy link
Author

htsnet commented Sep 17, 2019

Sorry @henriquearthur , I didn´t see your first comment.

Before I had used this plugin, I already have a ITEM tag, like this:

<item> <bitmap android:gravity="center" android:src="@mipmap/ic_launcher" /> </item>

Then, I run the plugin and, inside the launch_background.xml I saw the first one and this other:

<item> <bitmap android:gravity="center" android:src="@drawable/splash" /> </item>

When the app start, I saw a mess (2 images). Then I look for the issue and found this duplilcate entry.

It is not a big deal, I just remove the first one and everything is OK.

@henriquearthur
Copy link
Collaborator

The item this package looks for is android:src="@drawable/splash" to check if a entry was already added. As you had a android:src="@mipmap/ic_launcher" item, the package did not detected it.

This is normal because even using the package you are free to customize launch_background.xml manually.

@h2jose
Copy link

h2jose commented Dec 5, 2019

Sorry @henriquearthur , I didn´t see your first comment.

Before I had used this plugin, I already have a ITEM tag, like this:

<item> <bitmap android:gravity="center" android:src="@mipmap/ic_launcher" /> </item>

Then, I run the plugin and, inside the launch_background.xml I saw the first one and this other:

<item> <bitmap android:gravity="center" android:src="@drawable/splash" /> </item>

When the app start, I saw a mess (2 images). Then I look for the issue and found this duplilcate entry.

It is not a big deal, I just remove the first one and everything is OK.

This works for me, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants