_sass files could all be in extendable placeholders.

[AhoyLemon]

For the sass structure, do you think it might be helpful to rewrite the library using placeholders instead of classes? Ex:

%hamburger-slider-r {
  .hamburger-inner { }
}

That could help in a situation where somebody is getting the whole package but only want to use one of the transitions, and don't want to inflate the code with the ones they don't use.

[jonsuh]

Hey @AhoyLemon, I had initially thought of that but instead broke out each type as its own partial. If someone is using the Sass setup and does not want to include 1 or more styles, they can easily go to _sass/hamburgers/hamburgers.scss and comment out the types they don’t want:

// Types (Remove or comment out what you don’t need)
// ==================================================
@import "types/3dx";
@import "types/3dx-r";
@import "types/3dy";
@import "types/3dy-r";
@import "types/arrow";
@import "types/arrow-r";
@import "types/arrowalt";
@import "types/arrowalt-r";
@import "types/boring";
@import "types/collapse";
@import "types/collapse-r";
@import "types/elastic";
@import "types/elastic-r";
@import "types/emphatic";
@import "types/emphatic-r";
@import "types/slider";
@import "types/slider-r";
@import "types/spring";
@import "types/spring-r";
@import "types/stand";
@import "types/stand-r";
@import "types/spin";
@import "types/spin-r";
@import "types/squeeze";
@import "types/vortex";
@import "types/vortex-r";

Aside from that, I’m not sure if there’s added value of Extends as opposed to what’s currently in place, but all ears in the event I’m missing something and there’s a compelling reason to change it.

[christianmagill]

Commenting out source files of a package isn't the best scenario when using package managers such as Bower. It's expected that packages remain intact, and as such, the components themselves are often not committed with the projects they are included in.

[jonsuh]

@christianmagill Valid and great point! +@AhoyLemon Instead of extends, I came up with an alternate solution. I added another settings variable, $hamburger-types (a Sass list), that you can set to only include the types you want:

$hamburger-types (3dx, 3dy);

When you don’t set it, it includes all of the types by default. Here’s the commit: e914391

[christianmagill]

Looks great! Thanks

[resknow]

Just tried to compile Hamburgers using Sass and I get the following:

Import directives may not be used within control directives or mixins. AFAIK Sass doesn't allow conditional imports.

Compiles beautifully when I remove the @if statements :)

[jonsuh]

@resknow Hm. Curious, with what are you compiling the Sass with? And what version? Seems like it’s libsass related and the issue could be fixed in a latter version sass/libsass#1724

[resknow]

I'm using Ruby Sass v3.4.20 (Selective Steve).

[jonsuh]

@resknow Good to know! Apparently later versions of libsass allows @import in @if but Ruby Sass does not. I pushed a new release that should fix the issue https://github.com/jonsuh/hamburgers/releases/tag/v0.5.0 Would you mind testing it to confirm that it works or doesn’t?

[resknow]

@jonsuh Thanks! Works perfectly now.

[jonsuh]

Awesome! Gonna safely assume this issue is good to close