Drop jQuery, fix a number of XSS #364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ping @roland-d |
|
@dgrammatiko Awesome, it is on my todo list but no time yet. Will review later. |
|
fwiw I just converted the code, haven't tested it 😅 |
|
@dgrammatiko That is fine, that is why I did not merge it for this release :P Will review and test. |
heelc29
reviewed
Aug 27, 2023
|
@heelc29 I am currently reviewing/updating this PR. |
Co-authored-by: heelc29 <66922325+heelc29@users.noreply.github.com>
Signed-off-by: Roland Dalmulder <contact@rolandd.com>
|
@dgrammatiko I have tested this and there were quite a few things not working but all should be fixed now. Can you give it a check to see if there is nothing obvious wrong. Thanks. Indexing the pull requests works now :) |
|
LGTM, sorry for the silly mistakes 😀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue # .
Summary of Changes
Testing Instructions