-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test_run_hook_edit is not portable #196
Comments
Actually, that test isn't meant to depend on the environment, it overrides gitlint/gitlint/tests/cli/test_cli_hooks.py Lines 128 to 134 in 4a45133
That first Line 28 in 4a45133
Line 396 in 4a45133
I'm not sure why this test is failing for you then, there might be something wrong in my testing logic. Would need to dig in a bit deeper. FYI that I do have it on the roadmap to respect |
Interesting! FWIW, here's an extract of my settings:
Test results on your current main branch (commit 1a0ed8d, "Bump arrow from 1.0.3 to 1.1.1 (#210)"), of which it looks like many more are not portable:
|
test_run_hook_edit
relies on the default$EDITOR
value of the CI environment, which is not portable. For example, on Arch Linux the test fails with the following error:The test which doesn't set an editor should probably be removed, so that the test suite is more portable.
The text was updated successfully, but these errors were encountered: