Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to provide your own HTTP Client #85

Open
Hontaro opened this issue May 3, 2018 · 1 comment
Open

Add ability to provide your own HTTP Client #85

Hontaro opened this issue May 3, 2018 · 1 comment
Assignees

Comments

@Hontaro
Copy link

Hontaro commented May 3, 2018

In Unirest you had to provide your own HTTPClient via Unirest.setHttpClient(httpClient). This functionality has been lost with the RestClient.
The current ClientBuilder is missing customization options provided by the HttpClientBuilder such as setting your own SSL context.

@joshgontijo
Copy link
Owner

Yeah, it makes sense, the http-client API surface area is massive. The RestClient builder provides a very simplified configuration of the most used methods of it. I decided to stick with a minimal approach, and expand it on request basis. Will add SSL context for the builder and option to provide your own HttpClient on 1.6.1 release.

@joshgontijo joshgontijo self-assigned this May 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants