-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Full rewrite #35
Full rewrite #35
Conversation
…ullText and/or nocache params were passed
Would love to know when this might be merged upstream in a new official release? |
@yashvesikar Me too :D Feel free to test my fork in the meantime! |
Yep! I have been using it and have not run into any issues yet. Would be good to get this in the official release though. |
Any update on when this will be merged in? We are using the existing one now and it's a bit painful! |
@itsalysialynn For now, feel welcome to use This PR gets merged? Great! Remove "@wojtekmaj/" and you're ready to go. This PR doesn't get merged? Great! You're already using the only modern, maintained Jotform JS client. ;) |
Following support case no. 5388464 I'm happy to raise this PR with a full rewrite of Jotform API Node.js client.
Fixes #15
Fixes #20
Fixes #27
Fixes #29
Fixes #33
What's been done
New features
customHeaders
, allowing use ofjf-team-id
header.getFormReports
getFormReport
createFormReport
deleteFormReport
deleteFormSubmission
deleteReport
getPlan
Changes
addFormQuestions
missingformID
or passedquestionData
that isn't an object)..fail()
, and native Promise uses.catch()
to catch errors.request
with Fetch API - native Fetch API was added in Node.js 16.15.0 and 17.5.0 (hidden behind a flag) and is enabled by default since Node 18.0.0. Technically, Node.js backwards compatibility can be extended by addingnode-fetch
polyfill if needed. I personally consider this waste of time, as Node 18 is already LTS. Fixes Vulnerable Dependencies in Package #33.Maintenance
Bug fixes
addFormToFolder
method.fullText
option ignored ingetSubmissions
method.response.statusCode
was200
, butbody.responseCode
was not200
. Fixes Bad handling of API errors in library #27.getForms
andgetSubmissions
method when fullText and/or nocache params were passed.What still needs to be done
JOTFORM_API_KEY
GitHub Actions secret with a value that I'll provide to you via Jotform support channel.TEST_*_ID
inindex.spec.ts
file to gain full control over the data used in E2E tests and update the API key to an unlimited one.getHistory
tests are skipped because it takes super long for/user/history
to respond - I'm looking for an advice to resolve this, e.g. limit the amount of data requested?getSubusers
tests are skipped because I'm getting "User is not Allowed" error.deleteFolder
tests are skipped because DELETE requests to/folder/{folderID}
are not responded to - this has been already reported to you via support case no. 5393450.