Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SideNav header does not have enough height with long descriptions #129

Open
prince-chrismc opened this issue Nov 28, 2023 · 3 comments
Open

Comments

@prince-chrismc
Copy link

Firstly I really appreciate this project, makes docs so much more approachable for users ❤️

I ran into a tiny bug, the fixed height variable used for the main content header and side nav can sometimes conflict. For my case the description is longer then expected such that #top is using --top-height: and is cutting the search bar. Adjusting to 150px make the padding on main content to big.

Links to my copy running :)
https://prince-chrismc.github.io/jwt-cpp/
prince-chrismc/jwt-cpp@b97eb1b

Default

image

Shorter text

image

@jothepro
Copy link
Owner

Hm, good point! I wasn't aware of that side effect. I'm not sure if I would consider it a bug, but it definitely is not perfect.
Maybe it makes sense to decouple the contents top height from the sidebar variable. 🤔

I'll keep the issue open and think about it, feel free to contribute ideas in the meantime! 😊

@prince-chrismc
Copy link
Author

Thanks! I will try and fix it with a CSS overload and report back, playing in chrome its very likely fixable from the user side :)

@prince-chrismc
Copy link
Author

Here's my override.css https://github.com/prince-chrismc/jwt-cpp/blob/f7dedd0ac697f96a7a4b60ac01132e753c82e912/docs/overrides.css#L1-L17 which fixed it for my needs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants