Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.

fs.mkdir / fs.mkdirSync - mode parameter #1999

Closed
Bonuspunkt opened this issue Nov 3, 2011 · 3 comments
Closed

fs.mkdir / fs.mkdirSync - mode parameter #1999

Bonuspunkt opened this issue Nov 3, 2011 · 3 comments
Labels

Comments

@Bonuspunkt
Copy link

mode is ignored on windows, so it should be a optional parameter / have a default value

>node -v
v0.5.10

>node --eval "require('fs').mkdirSync('newDir')"

fs.js:361
  return binding.mkdir(path, modeNum(mode));
                 ^
TypeError: Bad argument
    at Object.mkdirSync (fs.js:361:18)
    at Object. (eval at  (eval:1:75))
    at Object. (eval:1:63)
    at Module._compile (module.js:432:26)
    at startup (node.js:84:14)
    at node.js:534:3
@bnoordhuis
Copy link
Member

bnoordhuis/node@11d68eb - review anyone?

@koichik
Copy link

koichik commented Nov 3, 2011

@bnoordhuis - LGTM.

@bnoordhuis
Copy link
Member

@koichik: Thanks! Merged in 11d68eb.

syntheticpp pushed a commit to syntheticpp/dartruntime that referenced this issue Nov 26, 2013
JamesXNelson pushed a commit to sdbg/sdbg that referenced this issue Jan 28, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants