Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.

Update README to reflect move to nodejs/node #25897

Closed

Conversation

orangemocha
Copy link
Contributor

Ref: #25876

The plan is for this PR to land during the transition of this repository to nodejs/node-v0.x-archive

/cc @joyent/node-tsc @rvagg

@rvagg
Copy link
Member

rvagg commented Aug 25, 2015

can you tag this as tsc-agenda and we'll get signoff in this week's meeting

@jasnell
Copy link
Member

jasnell commented Aug 25, 2015

LGTM but @rvagg is right, this should be reviewed on the call.

@Fishrock123
Copy link

Oh, didn't notice this was on joyent/node, carry on.

@bnoordhuis
Copy link
Member

Another LGTM if you want it.

@jasnell jasnell added the doc label Aug 27, 2015
- [community](https://github.com/joyent/node/wiki/Community)
- [contributing](https://github.com/joyent/node/wiki/Contributing)
- [big list of all the helpful wiki pages](https://github.com/joyent/node/wiki/_pages)
The pre-convergence version of the README is availalble [here](https://github.com/nodejs/node-v0.x-archive/blob/master/README-pre-convergence.md).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: available

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you! will fix

@jasnell
Copy link
Member

jasnell commented Aug 28, 2015

@orangemocha ... are we ready to go with this one?

@orangemocha
Copy link
Contributor Author

Yes, on Monday right after the repo move: #25876

@jasnell jasnell added the master label Aug 29, 2015
orangemocha added a commit that referenced this pull request Aug 31, 2015
Ref: #25876

PR-URL: #25897
Reviewed-By: jasnell - James M Snell <jasnell@gmail.com>
Reviewed-By: bnoordhuis - Ben Noordhuis  <info@bnoordhuis.nl>
@orangemocha
Copy link
Contributor Author

Landed in ed0d1c3. Thank you!

@Slayer95
Copy link

Slayer95 commented Sep 6, 2015

CONTRIBUTING.md needs to be updated as well, so that people will read it before trying to open issues.

@targos
Copy link
Member

targos commented Sep 6, 2015

We could also create a default branch with only the README like in https://github.com/joyent/libuv

@rvagg
Copy link
Member

rvagg commented Sep 6, 2015

I like that idea, @orangemocha what do you think about doing that here?

@orangemocha
Copy link
Contributor Author

Yes, sounds good. That doesn't need a PR, does it?

@orangemocha
Copy link
Contributor Author

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants