Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for newer java features #120

Closed
sebinside opened this issue May 31, 2021 · 3 comments
Closed

Add support for newer java features #120

sebinside opened this issue May 31, 2021 · 3 comments
Labels
enhancement Issue/PR that involves features, improvements and other changes language PR / Issue deals (partly) with new and/or existing languages for JPlag major Major issue/feature/contribution/change

Comments

@sebinside
Copy link
Member

A new or updated java language frontend shall be added which supports newer features like lambdas, switches, records, etc. This could, e.g., work with the next Java LTS version.
@sebinside sebinside added enhancement Issue/PR that involves features, improvements and other changes major Major issue/feature/contribution/change language PR / Issue deals (partly) with new and/or existing languages for JPlag labels May 31, 2021
@tsaglam
Copy link
Member

tsaglam commented Jul 12, 2021

With JPlag legacy I can parse newer Java features, however with with the current 3.0.0 pre-release I get an error: Error: Not enough valid submissions! (found 0 valid submissions). Thus this might not even be a problem with the Java9 frontend, as it could be a general bug caused by the rework. Source code: NewJavaFeatures.zip

We should also work on the error reporting, as this message is not specific enough.

@tsaglam tsaglam mentioned this issue Jul 12, 2021
Closed
@tsaglam tsaglam mentioned this issue Jul 21, 2021
Closed
@tsaglam tsaglam mentioned this issue Jul 28, 2021
Merged
@tsaglam
Copy link
Member

tsaglam commented Jul 28, 2021

The maven compiler level determines what source files the JavaC compiler can read. As the Java 9+ frontend uses the JavaC API, this affects what JPlag can parse.

@tsaglam
Copy link
Member

tsaglam commented Jul 28, 2021

Addressed by #159.

@tsaglam tsaglam closed this as completed Jul 28, 2021
@tsaglam tsaglam mentioned this issue Aug 4, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Issue/PR that involves features, improvements and other changes language PR / Issue deals (partly) with new and/or existing languages for JPlag major Major issue/feature/contribution/change
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tsaglam @sebinside