Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support unknown languages #1648

Merged
merged 1 commit into from
Mar 13, 2024
Merged

Support unknown languages #1648

merged 1 commit into from
Mar 13, 2024

Conversation

Kr0nox
Copy link
Member

@Kr0nox Kr0nox commented Mar 12, 2024

Fixes #1641

When the specified language is unknown, the report viewer no longer throws an error but rather continues with an unknown language and prints a warning to the console. The comparison view's default highlighting is Java highlighting.

@Kr0nox Kr0nox added the report-viewer PR / Issue deals (partly) with the report viewer and thus involves web-dev technologies label Mar 12, 2024
@Kr0nox Kr0nox requested a review from sebinside March 12, 2024 16:14
Copy link

sonarcloud bot commented Mar 12, 2024

Quality Gate Passed Quality Gate passed for 'JPlag Report Viewer'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@tsaglam tsaglam added bug Issue/PR that involves a bug minor Minor issue/feature/contribution/change labels Mar 13, 2024
@tsaglam tsaglam linked an issue Mar 13, 2024 that may be closed by this pull request
@tsaglam tsaglam merged commit ffcd7eb into develop Mar 13, 2024
40 checks passed
@tsaglam tsaglam deleted the report-viewer/unknown-language branch March 13, 2024 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue/PR that involves a bug minor Minor issue/feature/contribution/change report-viewer PR / Issue deals (partly) with the report viewer and thus involves web-dev technologies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Report viewer refuses reports with unknown language
2 participants