Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added progress bars for Match Merging and Token String Normalization. #1690

Merged
merged 1 commit into from
Apr 16, 2024

Conversation

TwoOfTwelve
Copy link
Contributor

Adds the progress bars from #1667.
This PR also contains a method, that allows to create progress bars using a functional syntax.

… Also added a functional style syntax for progress bars.
Copy link

sonarcloud bot commented Apr 9, 2024

@TwoOfTwelve TwoOfTwelve requested a review from uuqjz April 9, 2024 14:16
Copy link
Contributor

@uuqjz uuqjz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tsaglam tsaglam added enhancement Issue/PR that involves features, improvements and other changes minor Minor issue/feature/contribution/change labels Apr 10, 2024
@tsaglam tsaglam added this to the 5.1.0 milestone Apr 10, 2024
@Kr0nox
Copy link
Member

Kr0nox commented Apr 10, 2024

https://github.com/jplag/JPlag/blob/main/core/src/main/java/de/jplag/SubmissionSetBuilder.java Line 83 also uses a for loop and could be transformed into the new syntax. Do we want to do that?

@tsaglam tsaglam merged commit d1ce85d into develop Apr 16, 2024
35 checks passed
@tsaglam tsaglam deleted the feature/additionalProgressBars branch April 16, 2024 14:04
@tsaglam tsaglam mentioned this pull request Apr 17, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Issue/PR that involves features, improvements and other changes minor Minor issue/feature/contribution/change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants