Add workflow for closing issues on develop merge

[Kr0nox]

This PR adds a workflow that closes issues when they get merged into the develop branch.

The workflow itself starts a python script for this.
This script uses the GitHub GraphQL API to get all issues that were linked using the sidebar. It then parses the text of the PR to get all issues that are linked using closing keywords.
It then uses the REST API to close the linked issues.

As an example we have linked this issue:
closes #1597

[tsaglam]

@dfuchss this is the PR I mentioned.

[dfuchss]

Sounds good. Just two little improvement suggestions and then it should be ready to merge from my point of view. Nevertheless, I think it has to be merged to main too, that it works.

[Kr0nox]

Nevertheless, I think it has to be merged to main too, that it works.

In my testing it always worked when I did not have the workflow on main and also always took the newest version of the workflow, that was not on main. This would mean it takes the workflow from either the target branch or the branch the PR comes from

[dfuchss]

Nevertheless, I think it has to be merged to main too, that it works.

In my testing it always worked when I did not have the workflow on main and also always took the newest version of the workflow, that was not on main. This would mean it takes the workflow from either the target branch or the branch the PR comes from

Ok. Then it might not be needed.

[Kr0nox]

Now that we have the opportunity to close the issues with a custom message, do we want to add that the feature or bug fix will be released with the next release, so users do not think the feature is there already.
Currently, the bot just says Closed by #NUMBER. We could have them say something like:

Closed by #NUMBEr
The fix/feature will be part of the next release. If you want it now, you can build JPlag from the sources of the develop branch.

What are your opinions on that?

[tsaglam]

I think I would this is probably not needed, as the users who actually follow the development here are aware that there is a delay between the PR merge and the feature release. I would rather just stick to Closed by #NUMBER.

[Kr0nox]

the users who actually follow the development here

My though was that users that post issues might not do that and expect closed issues to be solved and ready for use, but in the end its up to you

[tsaglam]

At least from my experience, we have not yet received questions regarding such a case. We can always add it if this appears more frequently than in the past.

[Kr0nox]

ok, then from my point of view this should be ready to merge

[tsaglam]

@Kr0nox The workflow affected more PRs than expected, looks like a bug? (see referenced issues above)

EDIT: This is a matching issue, you are matching:

• 1
• 15
• 159
• 1597

[dfuchss]

Yes 1 .. 15 .. 159 .. 1597 .. there is probably a \b or similar missing :) Even the first issue is effected

[Kr0nox]

Yes, we did not check for a non number to be after the issue number, so it found all substrings of numbers of the actual issue.
#1748 provides a fix for this