Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update python language module #1750

Merged
merged 7 commits into from
May 16, 2024
Merged

Update python language module #1750

merged 7 commits into from
May 16, 2024

Conversation

TwoOfTwelve
Copy link
Contributor

@TwoOfTwelve TwoOfTwelve commented May 3, 2024

Added python grammar changes from the antlr repository.
Also migrated the language module to the new framework.

The token creation has not been altered, except for two new tokens for "async" and "await". That feature has been added to python since the language module was created. Except for that I did not find any big changes that JPlag needs to reflect.

Addresses #1669

@Kr0nox
Copy link
Member

Kr0nox commented May 4, 2024

Since after this the state of the python language module is no longer that of the legacy version do we want to change that in the README and docs?

@tsaglam tsaglam added enhancement Issue/PR that involves features, improvements and other changes minor Minor issue/feature/contribution/change language PR / Issue deals (partly) with new and/or existing languages for JPlag labels May 6, 2024
@tsaglam tsaglam changed the title Feature/python language module Update python language module May 6, 2024
@tsaglam

This comment was marked as outdated.

@TwoOfTwelve
Copy link
Contributor Author

There are still 4 sonar-cloud issues, but since they are in the files from the antlr-grammar I would suggest leaving them as is, so we don't have any changes compared to the antlr repository.

@tsaglam
Copy link
Member

tsaglam commented May 14, 2024

Since after this the state of the python language module is no longer that of the legacy version do we want to change that in the README and docs?

Yes, we should change it to beta. @TwoOfTwelve can you adapt the docs?

@TwoOfTwelve
Copy link
Contributor Author

I have changed it in the project README. As far as I know, that is the only place where we track the language module states.

Copy link

sonarcloud bot commented May 16, 2024

@tsaglam tsaglam merged commit 1a7c35d into develop May 16, 2024
40 checks passed
@tsaglam tsaglam deleted the feature/pythonLanguageModule branch May 16, 2024 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Issue/PR that involves features, improvements and other changes language PR / Issue deals (partly) with new and/or existing languages for JPlag minor Minor issue/feature/contribution/change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants