Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

content encoding #17

Closed
hansdesmedt opened this issue Feb 28, 2014 · 2 comments
Closed

content encoding #17

hansdesmedt opened this issue Feb 28, 2014 · 2 comments

Comments

@hansdesmedt
Copy link

in your code I see the following:

if(items[i].content)
bContent = true;
item.push({ 'content:encoded': { _cdata: items[i].content }});

I guess you forgot the "{}"

RESULT

If no content is present, 'content:encoded' is pushed to item. this results in an encoding problem because no namespace is present. Adding content is a quick fix.

@jpmonette
Copy link
Owner

Thanks @hansdesmedt. Next time, I'll have to look closer at pull requests people make ;)!

@fangel
Copy link

fangel commented Jul 8, 2014

Would it be possible to get a version-bump and a new patch-release on NPM, so it is possible to specify a dependency on this library that contains this fix?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants